[dev.icinga.com #584] Scheduled Downtime Notifications Resent On Restart/reload #284
Comments
Updated by mfriedrich on 2010-07-09 14:41:56 +00:00
|
Updated by mfriedrich on 2010-08-06 18:09:38 +00:00
base/notifications.c looks good. code below should behave like expected. probably the counter is somewhat truncated? needs more feedback though.
|
Updated by mfriedrich on 2010-09-17 15:30:50 +00:00
can you please have a look into that? |
Updated by ricardo on 2010-09-20 22:34:19 +00:00
here the fix for the problem. What happened here is, that a downtime is reschedule after restart. So it reads the status from the retention file, but it has no idea if the downtime is already started or not. Because the Flag "is_in_effect" isn't stored to the status or retention data. Added the flag status and retention data. Also to every function which is adding a downtime. And when icinga gets started then it will register and trigger a downtime event soon after start. Now following line takes effect:
It dose the job for my test environment. Can someone test this? |
Updated by mfriedrich on 2010-09-21 13:02:13 +00:00 haha i bet this breaks livestatus too by changing add_downtime function. although the command sending is not an intended usage by taking livestatus as an api. but i will apply and test, sure. |
Updated by ricardo on 2010-09-22 20:20:53 +00:00 as far as i could see, mk_livestatus isn't using any add_downtime function. I didn't changed the broker_calls. We can leave it like it is and the modules won't get this variable. In this case no module have to be changed. |
Updated by mfriedrich on 2010-09-22 20:45:10 +00:00 maybe we could make that an optional param somehow. but i think this flag is only used for internal functionality and shouldn't be reflected to the outside world. thanks for testing once more, tomorrow = mfriedrich/core |
Updated by mfriedrich on 2010-09-23 06:46:21 +00:00
up in mfriedrich/core for testing. |
Updated by mfriedrich on 2010-09-23 06:48:15 +00:00
Applied in changeset commit:"81eb1f32ac379212b688b788e0000048af61583f". |
Updated by mfriedrich on 2010-10-13 21:34:40 +00:00 possibly related to this report? http://www.nagios-portal.org/wbb/index.php?page=Thread&postID=137079#post137079 |
Updated by ricardo on 2010-10-14 17:24:07 +00:00
sorry guys, another fix which hasn't worked properly. Problem should be solved with commit: ddf93bb I hate it when I try to fix something and brake other stuff. I'm really sorry. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/584
Created by mfriedrich on 2010-07-08 16:18:03 +00:00
Assignee: ricardo
Status: Resolved (closed on 2010-09-23 06:48:15 +00:00)
Target Version: 1.3
Last Update: 2010-10-14 17:24:07 +00:00 (in Redmine)
http://tracker.nagios.org/view.php?id=124
Attachments
Changesets
2010-09-23 06:40:45 +00:00 by mfriedrich 81eb1f3
2010-10-14 16:55:20 +00:00 by ricardo ddf93bb
The text was updated successfully, but these errors were encountered: