[dev.icinga.com #5723] Mixing of declarations with code causes errors in GCC v2.95.3

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5723

Created by crfriend on 2014-03-06 23:32:33 +00:00

Assignee: crfriend
Status: Resolved (closed on 2014-03-08 13:59:37 +00:00)
Target Version: 1.11
Last Update: 2014-12-08 14:47:06 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

---

This was first detected whilst compiling Icinga 1.11.0 (on the "next" branch) on Solaris 10 Update 8 using GCC v2.95.3. It is compatibility only and the fix involves moving a single line in the source file for ido2db.

A branch and commit will follow once I have a tracking number.

Changesets

2014-03-06 23:38:57 +00:00 by crfriend 9a24a2f

Fix "Mixing of declarations with code causes errors in GCC v2.95.3" -- #5723

This patch moves a single declaration line in ido2db.c to get it away
from the code surrounding it.  This is a portability change only.

Note that the C90 standard technically prohibits intermixing of
declarations and code, but GCC, especially at lower levels, tends
to ignore that.

Fixes #5723

[icinga-migration]

Updated by crfriend on 2014-03-07 01:44:03 +00:00

• Status changed from New to Feedback

Commit pushed.

[icinga-migration]

Updated by mfriedrich on 2014-03-08 13:59:29 +00:00

• Target Version set to 1.11

[icinga-migration]

Updated by crfriend on 2014-03-08 13:59:37 +00:00

• Status changed from Feedback to Resolved
• Done % changed from 0 to 100

Applied in changeset icinga-core:9a24a2fa18b4df6071da013a5019cea1670d6e1a.

[icinga-migration]

Updated by mfriedrich on 2014-12-08 14:47:06 +00:00

• Project changed from 18 to Core, Classic UI, IDOUtils
• Category changed from 79 to IDOUtils
• Icinga Version changed from 1 to 1
• OS Version set to any