Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #5691] --enable-debug overwrites CFLAG settings in Makefile #1436

Closed
icinga-migration opened this issue Feb 21, 2014 · 3 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5691

Created by Tommi on 2014-02-21 17:02:14 +00:00

Assignee: Tommi
Status: Resolved (closed on 2014-03-03 20:23:57 +00:00)
Target Version: 1.11
Last Update: 2014-03-03 20:23:57 +00:00 (in Redmine)

Icinga Version: 1.10.3
OS Version: Solaris10

if i like to enable debug symbols with --enable-debug, previous defined CFLAGS are overwritten
Additional -Wall is not known at least by Solaris cc

# Compiler flags for use with Valgrind - set when debug is enabled
ifeq ('$(ENABLE_DEBUG)', 'yes')
    CFLAGS=-O0 -g -Wall -DHAVE_CONFIG_H -DNSCORE
endif

Solution: remove -Wall and replace CFLAGS= with CFLAGS+= in all Makefile.in

Changesets

2014-02-21 17:17:42 +00:00 by Tommi bc6a3c2

configure: remove -Wall and apend debug CFLAGS instead of replacing existing cflags #5691
refs #5691

2014-03-03 20:21:09 +00:00 by Tommi 1941096

configure: Remove -Wall and append debug CFLAGS.

Refs #5691

Signed-off-by: Michael Friedrich <Michael.Friedrich@netways.de>

2014-03-03 20:21:56 +00:00 by (unknown) e0a59bb

Merge branch 'fix/debug-overwrite-cflags-5691' into next

Fixes #5691

2014-03-03 21:34:07 +00:00 by (unknown) 2e60399

Update Changelog/THANKS.

Refs #5671
Refs #5687
Refs #5688
Refs #5687
Refs #5698
Refs #5684
Refs #5691
@icinga-migration
Copy link
Author

Updated by Tommi on 2014-02-21 17:20:39 +00:00

  • Status changed from New to Feedback
  • Done % changed from 0 to 100

changed in bc6a3c2

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-03-03 20:22:46 +00:00

  • Target Version set to 1.11

please assign the next release target for such fixes, otherwise they'll get lost during release planning.

@icinga-migration
Copy link
Author

Updated by Anonymous on 2014-03-03 20:23:57 +00:00

  • Status changed from Feedback to Resolved

Applied in changeset e0a59bb.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant