[dev.icinga.com #5525] Implement "form controllers"

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5525

Created by tgelf on 2014-01-20 18:21:34 +00:00

Assignee: jmeyer
Status: Resolved (closed on 2014-09-10 06:30:48 +00:00)
Target Version: 2.0-14
Last Update: 2014-09-10 06:30:48 +00:00 (in Redmine)

---

I'm unsure whether it where initial missunderstandings of MVC, Zend Form or even both of them. Fact is that some currently implemented forms look pretty obscure. I'd like to propose 'form controllers' as a base class for form-related application logic. Form elements should be grouped in 'form step' classes. A 'form controller' MAY also act as a multiform controller abstracting all the magic such as partial validation, session storage and navigating forth and back in dynamic wizard-like multistep forms.

Changesets

2014-07-10 09:09:48 +00:00 by jmeyer 1a1263d

Rename Icinga\Web\Form\Decorator\BootstrapForm

We do not use bootstrap anymore but do not want the default Zend
decorators either so this decorator got a more common name.

refs #5525

2014-07-10 09:13:45 +00:00 by jmeyer 0dce204

Refactor Icinga\Web\Form

We eagerly waited badly for a new approach to build forms, so here it is.
Should be the best compromise between the Zend_Form functionality and
our requirements regarding automatic submits.

refs #5525

2014-07-10 09:15:46 +00:00 by jmeyer 630b36e

Adjust Icinga\Form\Authentication\LoginForm to suit the new form builder

refs #5525

2014-07-10 09:16:31 +00:00 by jmeyer 6690410

Adjust Icinga\Form\Config\LoggingForm to suit the new form builder

refs #5525

2014-07-18 07:21:11 +00:00 by jmeyer 47ae4d7

Forms do not need a special title property

As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.

refs #5525

2014-07-18 07:24:49 +00:00 by jmeyer 21cd503

Form buttons need to be added explicitly

We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.

refs #5525

2014-07-18 07:27:10 +00:00 by jmeyer 802c095

Configuration values need to be inserted to forms explicitly

It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.

refs #5525

2014-07-18 07:33:09 +00:00 by jmeyer 58188c5

We only want to rely on Form::isValid() when about to process forms

As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.

refs #5525

2014-07-18 07:43:03 +00:00 by jmeyer 37fd3de

Rename initCsrfToken to addCsrfToken and move it upwards

Form::addCsrfToken() should be public and fluent to ensure more
flexibility.

refs #5525

2014-07-18 07:51:15 +00:00 by jmeyer 78a6175

Make form creation lazy and implement the new validation mechanism

Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.

refs #5525

2014-07-18 07:52:05 +00:00 by jmeyer 8f0b989

We cannot know what kind of data is passed to Form::isValid()

refs #5525

2014-07-18 07:52:50 +00:00 by jmeyer 6ac471c

Also mention the viewscript functionality of Form::loadDefaultDecorators()

refs #5525

2014-07-18 07:54:36 +00:00 by jmeyer f4ff2c9

It's a form's responsibility how its submit button should look like

refs #5525

2014-07-18 08:23:04 +00:00 by jmeyer 5da14d3

Adjust LoginForm to suit the "final" form builder implementation

refs #5525

2014-07-18 08:29:23 +00:00 by jmeyer 7157b11

Adjust LoggingForm to suit the "final" form builder implementation

refs #5525

2014-07-21 06:57:41 +00:00 by jmeyer f5ac592

Do not consider disabled elements when checking form completion

Values of disabled inputs are not sent by browsers.

refs #5525

2014-07-21 08:20:04 +00:00 by jmeyer a9f0b95

Adjust preferences form to suit the new form builder implementation

refs #5525

2014-07-21 12:33:52 +00:00 by jmeyer a73e2ee

Adjust general config form to suit the new form builder implementation

refs #5525

2014-07-21 13:25:00 +00:00 by jmeyer 75e09f2

Do not consider submit buttons when checking form completion

refs #5525

2014-07-23 08:57:46 +00:00 by jmeyer 0bf0213

Rename Form::addElement to Form::createElement

Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.

refs #5525

2014-07-23 08:58:45 +00:00 by jmeyer 8b2cc3a

Do not consider <button type=submit> when checking form completion

refs #5525

2014-07-23 10:35:39 +00:00 by jmeyer 9cdd891

Drop ReorderForm and handle its logic in the controller and view instead

refs #5525

2014-07-23 14:39:15 +00:00 by jmeyer 936f65e

Adjust resource form to suit the new form builder implementation

refs #5525

2014-07-23 14:39:54 +00:00 by jmeyer fd912da

Adjust createresource-action to suit the updated resource form interface

refs #5525

2014-07-24 06:45:38 +00:00 by jmeyer 4fe46a2

Remove unnecessary properties and their getters/setters

This kind of data is mainly prepared in the controller's action now or
directly fetched in a concrete form implementation.

refs #5525

2014-07-24 06:47:58 +00:00 by jmeyer 235c4a8

Remove getConfig and add get/setBackendConfig instead

As for every configuration form, backend forms need special population
mechanisms as well.

refs #5525

2014-07-24 06:49:47 +00:00 by jmeyer d8b468c

Add addSubmitButton to BaseBackendForm

refs #5525

2014-07-24 06:57:49 +00:00 by jmeyer edf49d0

Rewrite addForceCreationCheckbox and move it downwards

We should not instantiate form elements directly without any specific
reason.

refs #5525

2014-07-24 07:05:10 +00:00 by jmeyer 9c434fe

Make isValid more compact and fix coding style

refs #5525

2014-07-24 10:37:33 +00:00 by jmeyer 0964316

Adjust editresource-action to suit the new resource form interface

refs #5525

2014-07-24 14:17:30 +00:00 by jmeyer c3731fa

Adjust removeresource-action to suit the new resource form interface

refs #5525

2014-07-24 14:20:01 +00:00 by jmeyer 26a78dc

Remove properties from ConfirmRemovalForm and update it

Which object should be removed needs not to be a part of a form but is
accessible from the url's query string which should be in the action of the
form.

refs #5525

2014-07-25 06:58:11 +00:00 by jmeyer a6bd802

Remove unnecessary properties and its getters/setters

refs #5525

2014-07-25 06:58:50 +00:00 by jmeyer 26d42da

Re-add getResourcesByType as simplified version

refs #5525

2014-07-25 12:50:53 +00:00 by jmeyer 488ea46

Merge EditBackendForm with CreateBackendForm and rename it

It is not necessary to distinct between whether a backend is created or
edited as a user perhaps likes to change the name of a backend directly
instead of the need to remove and recreate it.

refs #5525

2014-07-25 12:55:36 +00:00 by jmeyer b743cf8

Adjust editbackend-action to suit the new backend-form interface

refs #5525

2014-07-25 13:58:44 +00:00 by jmeyer a78d113

Adjust createbackend-action to suit the new backend form interface

refs #5525

2014-07-25 14:00:38 +00:00 by jmeyer d7ed6bd

Adjust removebackend-action to suit the new backend form interface

Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.

refs #5525

2014-07-25 14:02:13 +00:00 by jmeyer 5a73811

Remove isExistingBackend/-Instance

It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.

refs #5525

2014-07-29 10:21:58 +00:00 by aklimov 5e6ef57

LdapBackendForm: replace create with createElements and getResources with __construct

refs #5525

2014-07-29 10:22:43 +00:00 by aklimov 4e1e845

DbBackendForm: replace create with createElements and getResources with __construct

refs #5525

2014-08-11 07:13:41 +00:00 by jmeyer c36e30a

Remove DbBackendForm::getConfig as it's not used anywhere

refs #5525

2014-08-11 08:39:13 +00:00 by jmeyer d260c3f

Do not overwrite __construct() in forms, there's init() for that purpose

refs #5525

2014-08-11 08:46:08 +00:00 by jmeyer f0a9927

Access backend information by using getValue() instead of getConfig()

refs #5525

2014-08-11 08:46:45 +00:00 by jmeyer a627571

Drop obsolete button elements

refs #5525

2014-08-11 12:49:42 +00:00 by jmeyer be14844

Merge EditInstanceForm with CreateInstanceForm and rename it

As with the backend form, a user might like to change the name of an
instance. The new form and its actions are also adjusted to suit the new form interface.

refs #5525

2014-08-12 07:49:27 +00:00 by jmeyer eea43e9

Adjust Icinga\Form\Dashboard\AddUrlForm to suit the new form interface

refs #5525

2014-08-12 08:41:19 +00:00 by jmeyer 4b1169c

Fix improper form submission

refs #5525

2014-08-12 08:42:28 +00:00 by jmeyer e6bcda2

Redirect after a new resource has been created successfully

refs #5525

2014-08-12 11:57:28 +00:00 by jmeyer fe63ce6

Make use if 'ignore´ instead of explicitly unsetting array keys

refs #5525

2014-08-12 12:43:10 +00:00 by jmeyer e7da9c0

Make our anti CSRF logic being a form element

refs #5525

2014-08-21 09:48:07 +00:00 by aklimov b81e965

SecurityForm: replace create() with createElements() and add addSubmitButton()

refs #5525

2014-08-21 09:51:49 +00:00 by aklimov d1b1bc3

Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid()

refs #5525

2014-08-22 10:04:14 +00:00 by jmeyer 2b879b3

Do not populate using createElements() and fix documentation blocks

refs #5525

2014-08-22 10:15:02 +00:00 by jmeyer 75a0c17

Ensure that all forms have a name

refs #5525

2014-08-22 13:20:54 +00:00 by jmeyer 7b221e2

It should not be a form's responsibility how its submit button should look..

...in case it's a standard button. No need to be DRY here.

refs #5525

2014-08-25 14:49:54 +00:00 by jmeyer c93ab79

Check whether a form's data was sent instead of whether it's complete

It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.

refs #5525

2014-08-25 15:06:45 +00:00 by jmeyer 52534a2

It is a form's responsibility to process the request it was submitted with

How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)

refs #5525

2014-08-26 10:30:37 +00:00 by jmeyer 5c7999f

Forms should be responsible for any redirection as well

If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.

refs #5525

2014-08-26 10:31:05 +00:00 by jmeyer 45cbd3f

We do not require the request being passed to handleRequest()

refs #5525

2014-08-27 08:09:29 +00:00 by jmeyer 98b2bce

Icinga\Web\Form::onSuccess() must not return TRUE

When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.

refs #5525

2014-08-27 08:10:55 +00:00 by jmeyer 65dd3f9

Make the form in view scripts accessible using $form instead of $element

refs #5525

2014-08-27 08:19:33 +00:00 by jmeyer d3c2fc8

Access formdata internally using a public helper method

This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.

refs #5525

2014-08-27 08:25:50 +00:00 by jmeyer 0ff79b0

Replace Form::onFailure() with Form::onShow()

There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.

refs #5525

2014-08-27 08:28:50 +00:00 by jmeyer 6783d51

A form is "submitted" when it was "sent" but no submit label was set

This enables us to use handleRequest() as is when no specific submit button
is required.

refs #5525

2014-08-27 11:14:40 +00:00 by jmeyer e132905

Do not hard code the name of the form identification element

Like the csrf element name the form identification element name should
be publicly accessible as well.

refs #5525

2014-08-29 07:04:20 +00:00 by jmeyer 486104d

Check explictly for FALSE when calling onSuccess()

This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.

refs #5525

2014-08-29 07:08:53 +00:00 by jmeyer bf23688

Make autosubmit work in non-JS enviroments

We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.

refs #5525

2014-08-29 10:21:31 +00:00 by jmeyer 79b0ed6

Make it possible to provide a closure to be called instead of onSuccess()

This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.

refs #5525

2014-08-29 10:25:25 +00:00 by jmeyer 364c7c0

Add base form class for configuration forms

refs #5525

2014-08-29 13:16:13 +00:00 by jmeyer ae35650

Adjust authentication backend forms to suit.. some form implementation

refs #5525

2014-09-01 07:44:04 +00:00 by elippmann f3e74f0

library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set

Before, the class attribute would've been overwritten.

refs #5525

2014-09-01 12:40:45 +00:00 by elippmann 0822aff

library/form: Fix return value of `getName()' not being filterd the first time it's called

`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.

refs #5525

2014-09-01 12:58:16 +00:00 by jmeyer cd8015f

Pass the current form instance to the callback as second argument

refs #5525

2014-09-01 13:11:09 +00:00 by jmeyer 0e63e36

Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form

This is a generic form not necessarily being used just for configuration
purposes.

refs #5525

2014-09-01 14:16:56 +00:00 by jmeyer deebb64

Adjust Icinga\Form\Config\General* to use handleRequest() & Co.

refs #5525

2014-09-02 13:04:23 +00:00 by elippmann 7143837

lib: Remove `ElementWrapper' form element decorator

Zend has a `Label' decorator already.

refs #5525

2014-09-02 13:05:47 +00:00 by elippmann 8478ef3

lib: Remove `HelpText' form element decorator

Zend already has a `Description' decorator.

refs #5525

2014-09-02 13:23:07 +00:00 by elippmann d4c4ab7

lib/form: Fix default element decorators but breaking noscript layout

Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.

Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.

refs #5525

2014-09-02 14:19:45 +00:00 by jmeyer 39bb01b

Rename Icinga\Web\Form::onShow() to onRequest()

onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525

2014-09-02 14:25:03 +00:00 by jmeyer 539ab91

Add the FormErrors decorator as default decorator for forms

This allows us to use Zend_Form::addError() to show error messages for
the entire form context.

refs #5525

2014-09-02 14:25:03 +00:00 by jmeyer 5b14d8f

Fix that the force_creation checkbox disappears after another error

Once the user enters invalid data after he tried to save a backend without
success (because the backend was not successfully validated) the shown
checkbox disappeared in this case regardless of whether it was checked
or not.

refs #5525

2014-09-02 14:25:03 +00:00 by jmeyer 2d86e6b

Rename ResourceForm and make it use handleRequest() & Co.

refs #5525

2014-09-02 14:50:59 +00:00 by jmeyer 95c839a

Remove remaining usages of the ElementWrapper- and HelpText-Decorator

refs #5525

2014-09-02 14:54:43 +00:00 by elippmann 5485ca8

lib: Use Zend's `Int' validator in the `Number' form element

Further disabled default decorators since our form sets them.

refs #5525

2014-09-02 14:54:43 +00:00 by elippmann c7a4098

lib: Respect the disabled attribute in `FormNumber'

refs #5525

2014-09-02 15:03:51 +00:00 by jmeyer 5ce9bef

Replace usages of the `helptext' form element option with `description'

refs #5525

2014-09-02 15:08:54 +00:00 by elippmann dd3901e

`FormNumber': Fix "The use statement with non-compound name..."

refs #5525

2014-09-03 10:21:31 +00:00 by jmeyer 54a8342

Form::createElements() should add elements instead of returning them

In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().

refs #5525

2014-09-03 13:08:37 +00:00 by jmeyer 49562e7

Adjust ..\Monitoring\Form\Config\SecurityForm to use handleRequest()

refs #5525

2014-09-04 06:47:16 +00:00 by jmeyer 9d66cc9

Adjust Monitoring\InstanceForm to use handleRequest() & Co.

refs #5525

2014-09-04 09:25:47 +00:00 by jmeyer 439d189

Adjust Monitoring\BackendForm to use handleRequest() & Co.

refs #5525

2014-09-05 07:16:09 +00:00 by jmeyer 8846f17

Make it possible to disable form identification

refs #5525

2014-09-05 07:17:09 +00:00 by jmeyer d021747

Fix form widgets

refs #5525

2014-09-05 08:21:24 +00:00 by jmeyer fc72ddf

Adjust Preferences/GeneralForm to use handleRequest() &. Co.

refs #5525

2014-09-08 07:24:53 +00:00 by jmeyer 930e6e7

We shouldn't require Form::createElements() to return self

refs #5525

2014-09-08 07:42:02 +00:00 by jmeyer 12b4865

Fix incompatible declaration of Form::setDefaults()

PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()

refs #5525

2014-09-08 11:31:25 +00:00 by jmeyer f53519c

Rename ConfigForm::setConfig() to ConfigForm::setIniConfig()

We do not want to override Zend_Form::setConfig() so this renaming is
required. set*Ini*Config() because ConfigForm::save() utilizes an ini-writer
to persist the configuration to disk.

refs #5525

2014-09-09 07:27:04 +00:00 by jmeyer c8bdb70

Remove command form tests

refs #5525

2014-09-09 07:30:33 +00:00 by jmeyer c8ce108

Disable checking whether a form is sent when form identification is disabled

refs #5525

2014-09-09 07:31:15 +00:00 by jmeyer f7f6bcc

Make Form base class more test friendly..

refs #5525

2014-09-09 07:40:49 +00:00 by jmeyer 6525d69

Add test for Icinga\Web\Form

refs #5525

2014-09-09 08:36:42 +00:00 by jmeyer 31978e1

Fix LdapBackendFormTest

refs #5525

2014-09-09 08:39:49 +00:00 by jmeyer e4fccdd

Fix DbBackendFormTest

refs #5525

2014-09-09 09:58:07 +00:00 by jmeyer 7dbc83e

Drop obsolete BaseBackendFormTest

refs #5525

2014-09-09 10:02:51 +00:00 by jmeyer 40947ac

Fix, rename and move ReorderFormTest

refs #5525

2014-09-09 11:06:30 +00:00 by jmeyer 0693e7c

Fix ResourceForm tests

refs #5525

2014-09-09 11:22:51 +00:00 by jmeyer 6bde740

Fix Icinga\Form\ConfigForm show config feature not available for modules

refs #5525

2014-09-09 11:24:39 +00:00 by jmeyer ceeb3a9

Fix createElements() not returning self where applicable

refs #5525

2014-09-09 13:00:33 +00:00 by jmeyer e7c0218

Simplify subform usage

refs #5525

---

Relations:

• relates #5525
• relates #5525
• relates #5525
• relates #4678
• relates #5525
• relates #5967
• blocks #6059
• blocks #6593

[icinga-migration]

Updated by elippmann on 2014-01-21 14:39:00 +00:00

• Category set to Framework
• Target Version set to Backlog

[icinga-migration]

Updated by mhein on 2014-02-04 13:22:51 +00:00

• Target Version changed from Backlog to 2.0-2

[icinga-migration]

Updated by elippmann on 2014-02-12 09:29:28 +00:00

• Status changed from New to Assigned
• Assigned to set to elippmann

[icinga-migration]

Updated by elippmann on 2014-03-14 14:02:17 +00:00

• Assigned to deleted elippmann

[icinga-migration]

Updated by elippmann on 2014-03-14 16:08:17 +00:00

• Target Version changed from 2.0-2 to 2.0-3

[icinga-migration]

Updated by elippmann on 2014-06-01 11:59:59 +00:00

• Status changed from Assigned to Feedback
• Assigned to set to jmeyer
• Target Version changed from 2.0-3 to 2.0-5

Hi Johannes,

Since you're working on this issue, I'll assign it to you. Is this fully implemented?

Cheers,
Eric

[icinga-migration]

Updated by jmeyer on 2014-06-02 08:22:58 +00:00

• Status changed from Feedback to Assigned

Hi Eric,

yes it's fully implemented (see #6136), but based on our current form mechanics. Once this changes, the current implementation of this issue will change as well. So it's still WIP and not finished.

[icinga-migration]

Updated by icinga-kanban on 2014-07-10 09:18:59 +00:00

Build !#1577 triggered by commit 6690410 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-18 07:56:28 +00:00

Build !#1616 triggered by the commits f4ff2c9, 6ac471c, 8f0b989, 78a6175, 37fd3de, 58188c5, 802c095, 21cd503, 47ae4d7, 1de2d0c, 4d19918, b7f5c8a, b23e36a, 62da942, bfc54b7, 5c507d5, 1ad2631, eb977b7, f1d7cd8, cb04c42, e5fdf78, e6dee9f, b40027b, 19f0525, 8086292, 4c415aa, c7c2ad3, 333c95e, 3105c20, 861f9e0, 39cd4a4, e7a8c3b, d021dde, e567ad6, a40feeb, bacea36, 5908e9f, ec2d1da, b046023, ab410de, b4dc0f3, 53f3d74, 3c9d2b0, d22363d failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-21 08:22:38 +00:00

Build !#1621 triggered by the commits a9f0b95, f5ac592, 6ed3d5f, 7157b11, 5da14d3 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by elippmann on 2014-07-21 12:22:46 +00:00

• Target Version changed from 2.0-5 to 2.0-10

[icinga-migration]

Updated by icinga-kanban on 2014-07-21 13:44:30 +00:00

Build !#1625 triggered by the commits 75e09f2, a73e2ee failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-23 10:35:57 +00:00

Build !#1634 triggered by the commits 9cdd891, 8b2cc3a, 0bf0213, 25c9ee5 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-23 14:40:33 +00:00

Build !#1639 triggered by the commits fd912da, 936f65e, c8d61f7 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-24 07:07:19 +00:00

Build !#1640 triggered by the commits 9c434fe, edf49d0, d8b468c, 235c4a8, 4fe46a2 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-24 14:20:23 +00:00

Build !#1641 triggered by the commits 26a78dc, c3731fa, 0964316 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-25 12:56:19 +00:00

Build !#1642 triggered by the commits b743cf8, 488ea46, af5a326, 26d42da, a6bd802, 5f76521 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-07-25 14:03:19 +00:00

Build !#1644 triggered by the commits 5a73811, d7ed6bd, a78d113, 02c3223, ed10e49, 644b3a1, c06db74, 50de21e, af898cc, 1902b4f failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by jmeyer on 2014-07-25 14:11:47 +00:00

• Done % changed from 0 to 80

Most configuration forms are finished. Not finished are the following:

• Icinga\Form\Config\Authentication\DbBackendForm (action and base-class were updated)
• Icinga\Form\Config\Authentication\LdapBackendForm (action and base-class were updated)
• Icinga\Form\Dashboard\AddUrlForm
• Icinga\Module\Monitoring\Form\Config\Instance\CreateInstanceForm (should be merged into its edit counterpart)
• Icinga\Module\Monitoring\Form\Config\Instance\EditInstanceForm

Additionally all widgets and command forms (actually not a subject to this issue) are still not updated.

[icinga-migration]

Updated by aklimov on 2014-07-28 10:41:38 +00:00

• Assigned to changed from jmeyer to aklimov

[icinga-migration]

Updated by elippmann on 2014-07-29 09:39:12 +00:00

• Target Version changed from 2.0-10 to 2.0-11

[icinga-migration]

Updated by icinga-kanban on 2014-07-29 10:27:39 +00:00

Build !#1733 triggered by the commits e07f2a2, 4e1e845, 5e6ef57 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Alexander Klimov

[icinga-migration]

Updated by aklimov on 2014-07-29 11:06:02 +00:00

• Done % changed from 80 to 90

[icinga-migration]

Updated by aklimov on 2014-07-30 12:25:38 +00:00

• Assigned to changed from aklimov to jmeyer

Icinga\Form\Config\Authentication\*BackendForm are finished

[icinga-migration]

Updated by icinga-kanban on 2014-08-11 08:52:03 +00:00

Build !#1748 triggered by the commits a627571, f0a9927, 5203f82, a37e65b, d260c3f, c36e30a failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-11 14:38:09 +00:00

Build !#1749 triggered by commit be14844 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-12 07:50:38 +00:00

Build !#1751 triggered by the commits f23bf91, eea43e9 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by jmeyer on 2014-08-12 08:17:43 +00:00

• Relates set to 5967

[icinga-migration]

Updated by jmeyer on 2014-08-12 08:21:48 +00:00

Icinga\Form\Dashboard\AddUrlForm and Icinga\Module\Monitoring\Form\Config\Instance\* are now finished as well.

There is a regression from #5967 and another bug caused by not setting any action on forms. (Results in not being able to properly submit forms when not displayed in the very first column.)

[icinga-migration]

Updated by icinga-kanban on 2014-08-12 11:59:34 +00:00

Build !#1754 triggered by the commits fe63ce6, e6bcda2, 4b1169c failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by jmeyer on 2014-08-22 13:27:36 +00:00

• Target Version changed from 2.0-11 to 2.0-12
• Done % changed from 90 to 50

We just changed our mind how forms should behave, actually. So 50% from now on ... and a new target version! :)

[icinga-migration]

Updated by icinga-kanban on 2014-08-25 15:07:18 +00:00

Build !#1822 triggered by the commits 52534a2, c93ab79, 7b221e2 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-26 10:32:05 +00:00

Build !#1834 triggered by the commits 45cbd3f, 5c7999f failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-27 08:31:00 +00:00

Build !#1841 triggered by the commits 6783d51, 0ff79b0, d3c2fc8, 65dd3f9, 98b2bce failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 07:13:08 +00:00

Build !#1871 triggered by the commits bf23688, 486104d, e132905 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 13:16:43 +00:00

Build !#1879 triggered by the commits ae35650, 364c7c0, e020dd3, 79b0ed6 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 14:09:49 +00:00

Build !#1882 triggered by the commits fb5685b, 055a107, 3642b7b, a26370b, e799d65, 648debf, 00a2d22, c5cface, 98809a1, a9eec0d, f77cd9c, 573a4ea, 0da16e4, 0a2b504, c4c5bcd, dea7caa, 4e83bb0, e345aa2, 436a4d2, 9d0037a, 35d11bd, 9b83074, 22e17e9, c194c02, fdef695, 66062c8, 947cd0c, 6a32c3a, e342035, 5e84ff4, 9465c3f, 70fdd58, 8b0df6c, e6612fe, afd0c20, 45638b2, 7ff51ca, 968fa36, 66031ed, 236d384, 4a59ff6, 1dea195, 24983c3, 88698cb, b7ae66b, e0d7c38, 87a5967, 5abf41e, 89541f5, 7e5b5a0, 1aa95b0, 1ff63db, ff1d2e4, 746f53f, 23aa57a, 2575634, 376e9aa, 3a85a45, c8643ab, aec6657, 1f7d4cb, a2011b1, febb2d1, d8bbd7a, 4ec6dbe, 42e2b34, bae5ba2, af0cf48, 1112744, b60c359, 7d25efb, f754531, 7074fa1, 6c99473, f4dbb4d, 013aad8, 70fe22d, 5c46355, c31972b, a5373a6, 9c5878c, 20cead6, aba5b1c, 1886569, da821fd, f757f69, 7e0047d, 49cd55e, 968fa0a, b764993, 1e891c2, b55a313, 09412d0, af97db3, 8733238, 30d0ebc failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 07:46:26 +00:00

Build !#1885 triggered by commit f3e74f0 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 12:49:58 +00:00

Build !#1892 triggered by commit 0822aff failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 14:17:17 +00:00

Build !#1901 triggered by the commits deebb64, 0e63e36, cd8015f failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by elippmann on 2014-09-02 10:57:26 +00:00

• Target Version changed from 2.0-12 to 2.0-14

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 13:06:34 +00:00

Build !#1920 triggered by the commits 8478ef3, 7143837 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 13:25:36 +00:00

Build !#1922 triggered by commit d4c4ab7 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 14:26:22 +00:00

Build !#1932 triggered by the commits 5464321, 1ba3df3, 2d86e6b, 5b14d8f, 539ab91, 338f549, aedc8cc, 39bb01b failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 14:51:43 +00:00

Build !#1938 triggered by commit 95c839a failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 14:54:54 +00:00

Build !#1940 triggered by the commits c7a4098, 5485ca8 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 15:05:57 +00:00

Build !#1942 triggered by commit 5ce9bef failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 15:09:06 +00:00

Build !#1943 triggered by commit dd3901e failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-03 10:21:53 +00:00

Build !#1952 triggered by commit 54a8342 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-04 15:06:39 +00:00

Build !#1986 triggered by the commits 439d189, 9d66cc9, 49562e7 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-05 08:57:55 +00:00

Build !#2001 triggered by the commits fc72ddf, 7d21265, d021747, 8846f17 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-08 07:11:46 +00:00

Build !#3 triggered by commit 7215e27 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by icinga-kanban on 2014-09-09 14:05:09 +00:00

Build !#8 triggered by the commits 83772c6, 7d45384, 71f55e3, b7c207a, e7c0218, 157818c, ceeb3a9, 6bde740, 0693e7c, 9d8f810, 40947ac, 7dbc83e, e4fccdd, 31978e1, cee3c32, a5c027b, d6377ca, c947ba3, 6525d69, f7f6bcc, c8ce108, 34bbe65, c8bdb70, 1137c01, 56b779a, 28f5ef2, a352131, 4061165, 0fd5619, 545db94, f53519c, e8d526f, 7386ae5, 2112d45, e8164c6, e39dd64, 12b4865, 39688ec, 930e6e7, c304c23, 7d623fd, 6095e44, 4a89c2e, ccb8f51, cbaa2d8, adab58e, 22b3b0e, d1dae46, fe6a1b1, 9ea377f, 48f49c5, 38c6d6a, 949ea1c, 51d14af, 3fbf172, 6689fab, 66dba8b, 4da3f55, 19eca5f, 596800b, 315c2a6, d4d3c77, 65b2a25, c312139, caab729, 4bb065d, e0dc972, c041bcc, 6e33061 failed.

Branch: origin/bugfix/rebuild-form-builder-5525
Author: Johannes Meyer

[icinga-migration]

Updated by jmeyer on 2014-09-09 14:10:51 +00:00

• Done % changed from 50 to 90

[icinga-migration]

Updated by jmeyer on 2014-09-10 06:30:48 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 90 to 100

The form base class as well as everything (but the command forms) inheriting from it has been adjusted. Work continues with #6593.

[icinga-migration]

Updated by elippmann on 2014-09-15 07:52:29 +00:00

• Blocks set to 6593