[dev.icinga.com #4678] Tests: Mock request instead of arming classes with functions that override preferences/configuration

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/4678

Created by elippmann on 2013-09-05 12:01:46 +00:00

Assignee: (none)
Status: Closed (closed on 2014-09-09 14:09:47 +00:00)
Target Version: 2.0-14
Last Update: 2014-09-09 14:09:47 +00:00 (in Redmine)

---

I refer for example to Icinga\Web\Form which provides the functions setUserPreferences and setConfiguration where the overriden values will be used instead of retrieving them from the request. Especially base classes must not have such bloat. Use mocks instead.
Further Icinga\Module\Monitoring\Form\Command\CommandForm::getAuthorName() returns Test user if the request is of type Zend_Controller_Request_HttpTestCase. Drop that.

---

Relations:

• relates #4678

[icinga-migration]

Updated by elippmann on 2013-10-25 12:04:03 +00:00

• Target Version changed from 147 to 140

[icinga-migration]

Updated by mhein on 2013-12-23 13:18:53 +00:00

• Tracker changed from Feature to Bug

[icinga-migration]

Updated by jmeyer on 2014-09-09 14:09:47 +00:00

• Status changed from New to Closed
• Target Version changed from 140 to 2.0-14
• Done % changed from 0 to 100

Fixed mostly as part of #5525