Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #3820] increase performance on host->service relation counter (config reading, flapping) #1234

Closed
icinga-migration opened this issue Mar 10, 2013 · 2 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3820

Created by mfriedrich on 2013-03-10 19:17:50 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2013-04-06 21:43:16 +00:00)
Target Version: 1.9
Last Update: 2013-04-06 21:43:16 +00:00 (in Redmine)


currently, services are only checked against their link to the host, but the host object itsself is not updated on the number of linked hosts - that happens later on the preflight check itsself.

while the number is also an indicator for the warning "host has no services associated", the more interesting part is the flapping detection where the total service check interval needs to be taken into account as well somehow.

in order to solve the inefficient pre flight "loop again over all services and check the host relation and update values" we'll do that directly within the link check and only check the numbers later on.

inspired by https://github.com/dnsmichi/nagios-svn/commit/1aca8a358a001e1940ad6cc6be0a695d94340c6b but fixed for flapping.

Changesets

2013-03-10 19:24:40 +00:00 by (unknown) caa849b

core: increase performance on host->service relation counter (config reading, flapping)

when a service is checked against its host association we can already
update the relation counter as well as total check interval.

the first is required for the config pre flight check while the second
is used within flapping detection.

original patch by Andreas Ericsson, fixed for usage in Icinga.

refs #3820

2013-03-11 22:30:44 +00:00 by (unknown) 56e2d28

fix leftover from refs #3531 #3820
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-03-13 23:18:13 +00:00

  • Status changed from Assigned to Feedback
  • Done % changed from 0 to 80

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-04-06 21:43:16 +00:00

  • Status changed from Feedback to Resolved
  • Done % changed from 80 to 100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant