Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #3390] keep logfile open, reducing open/close performance decreases #1142

Closed
icinga-migration opened this issue Oct 24, 2012 · 3 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3390

Created by mfriedrich on 2012-10-24 14:48:42 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2013-04-06 21:42:52 +00:00)
Target Version: 1.9
Last Update: 2013-04-06 21:42:52 +00:00 (in Redmine)


must determined and profiled, but the general idea is clear.

https://github.com/dnsmichi/nagios-svn/commit/0cc2818de8b910d87fb05ef8993e47c71273b7b5
https://github.com/dnsmichi/nagios-svn/commit/676804efe1312558395e04640ac6743b65488d97
https://github.com/dnsmichi/nagios-svn/commit/0f7b8c8a5fe457de17513452e66ff6ecb797d3b3

Changesets

2013-03-10 13:58:23 +00:00 by (unknown) 161d511

core: fix triggered downtimes for child hosts are missing after icinga restart (thx Michael Lucka) #3390

basically, the issue is 2 folded:

- the downtimes are somewhat whackily sorted in memory after being read
  from status.dat/retention.dat
- that sort order (by start time) will not allow to to check for valid
  parent downtimes when a child downtime is considered valid or invalid

the patch changes the sort order of downtimes in memory and assumes that

- parent and child downtimes have the same start time
- downtime_ids are ascending, parent before child

requires further tests, thanks Michael Lucka for the patch and analysis.

refs #3390

2013-03-10 14:56:00 +00:00 by (unknown) 7aab352

core: keep logfile open, reducing open/close performance decreases

the only caveat on this - when a kernel panic happens, the last fflush()
may be missed, since the buffers now reside on the kernel side, and we
do not open/close (commit) the log on every single line.

refs #3390
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-02-21 19:22:40 +00:00

  • Category set to Logging
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-03-13 23:17:42 +00:00

  • Status changed from Assigned to 7
  • Done % changed from 0 to 100

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-04-06 21:42:52 +00:00

  • Status changed from 7 to Resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant