[dev.icinga.com #300] fix sending two identical service_status events to neb module

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/300

Created by mfriedrich on 2010-02-23 14:10:19 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2010-02-23 14:15:06 +00:00)
Target Version: 1.0.1
Last Update: 2010-02-23 14:15:06 +00:00 (in Redmine)

---

http://tracker.nagios.org/view.php?id=4

from nagios-devel

==
-------- Original Message --------
Subject: Re: [Nagios-devel] Host and Services update fonction called twice
Date: Tue, 23 Feb 2010 14:12:24 +0100
From: Andreas Ericsson <ae@op5.se>
Reply-To: Nagios Developers List <nagios-devel@lists.sourceforge.net>
To: Nagios Developers List <nagios-devel@lists.sourceforge.net>
References: <ae2be7a00905140128l519e6ccfo8b1e06c160ad97a0@mail.gmail.com> <4A0BD7B6.50607@op5.se> <ae2be7a00905140220r11389ed8v6a0b0d1a1c38bdec@mail.gmail.com> <4A0C0427.6040200@op5.se> <11966f020905140852w4262643bm4a7e1f467c1f4e61@mail.gmail.com> <4A0C5E4B.3080205@op5.se> <11966f020905150003o31795405o9d8f7185b3de8965@mail.gmail.com> <4A0D3FF2.7020501@op5.se> <11966f020905150355y5cbdc3a9ye443faa9947a224d@mail.gmail.com> <11966f021002220751r7b62e3a9wc247c875c13a0301@mail.gmail.com>

On 02/22/2010 04:51 PM, Matthieu Kermagoret wrote:

On Fri, May 15, 2009 at 11:55 AM, Matthieu Kermagoret
<mkermagoret@merethis.com> wrote:
> This issue has been successfully reproduced on Nagios 3.0.6, 3.1.0 and
> the latest CVS revision with NDOUtils 1.4b7.
>

Can still be reproduced with latest Nagios CVS revision. This is now
the oldest unassigned issue within Nagios' tracker
(http://tracker.nagios.org/view.php?id=4) :-(

You'll find attached a patch which tries to correct Nagios' behavior.
It causes host/service status not to be updated when check is
scheduled but only when check results are processed. Is there any
weird case that would cause this logic to fail ?

The patch seems correct, but the description of it isn't. Status
updates should take place whenever there is a modification to the
state of the service. This is important, since a GUI needs the
next_check information (and suchlike) to properly draw the scheduling
queue. Such updates should ofcourse only come once, so this patch
is still correct.

Will apply. Thanks.

Changesets

2010-02-23 14:14:24 +00:00 by mfriedrich 9a0d5ba

fix sending two identical service_status events to neb module

fixes #300

[icinga-migration]

Updated by mfriedrich on 2010-02-23 14:15:06 +00:00

• Status changed from New to Resolved
• Done % changed from 0 to 100

Applied in changeset commit:"9a0d5baff02fd76f477d5634dccc2700a0c228a9".