Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #2904] add worker management helpers from libicinga to core #1040

Closed
icinga-migration opened this issue Jul 27, 2012 · 2 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2904

Created by mfriedrich on 2012-07-27 08:40:55 +00:00

Assignee: mfriedrich
Status: Closed (closed on 2012-08-22 18:19:26 +00:00)
Target Version: exp
Last Update: 2012-08-22 18:19:26 +00:00 (in Redmine)


using libicinga and the worker library, this adds the arbitrary connection between the lib and the core in order to add new jobs to the queue, spawn new workers, and use the overall implemented architecture within #2900 #2901 #2902 #2903

libicinga itsself stays put, and can be included by addons or testsuits, not interfering with the core itsself.

original author is Andreas Ericsson, we might adopt some namings plus work on the FIXMEs ourselves, proposing any to Nagios then, if applicable while testing this.

this remains experimental, lives only on dev/* branches.

Changesets

2012-07-27 11:31:45 +00:00 by mfriedrich 20f68527acbe280488d58eef339fcde4c281b42f

core: add worker management helpers from libicinga<->icinga #2904

based on the workers library provided with libicinga, we can now add the
arbitrary connection to the core, adding new jobs to the queue, spawning
new workers to handle those jobs, using the architecture built in #2900
+ #2901 + #2902 + #2903.

this also adds the struct rusage to the checkresult struct to determine
the resources a plugin will be using, keeping track of its consumation.

original patch done by Andreas Ericsson, slightly modified to match
Icinga. there are various FIXMEs around the place, such as

- check job->id against job_id and do something if they do not match
- when a worker died on result handling, spawn a new one, and distribute
  all unifinished jobs over there
- if checkresult buffer is not convertable to a key/value vector, log an
  error
- if the worker is busy, find a new less busy one
- add environment macros to the workers, which does not work for now

so there's still work to do, but for an experimental prototype this is
very well done for now.

refs #2904

2012-07-27 18:46:28 +00:00 by mfriedrich 00f9934a52a098953161fc6ea2b6954db20d6edc

core: log as info how many workers have spawned

refs #2904
refs #2909

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-08-07 16:50:12 +00:00

  • Target Version set to exp

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-08-22 18:19:26 +00:00

  • Status changed from Assigned to Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant