You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Created by mfriedrich on 2012-06-11 15:39:04 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2012-08-25 13:35:55 +00:00)
Target Version: 1.7.2
Last Update: 2012-08-25 13:35:55 +00:00 (in Redmine)
Icinga Version: 1.7.1
OS Version: Debian
from the 1.7 released new_event "hash" logic, a replacement patch, origin nagios svn, andreas ericsson. needs proper analysis and discussion, next to tests.
core: unify check scheduling replacement logic for new events (Andreas Ericsson) #2676
previously, the logic on scheduling a new event was changed using the
new_event attribute. the decision for actually scheduling a new event
now happens generalized after having decided to actually do so.
furthermore next_check_event is correctly assigned to that new event for
the host|service check (which may be a bug in previous versions).
refs #2676
* core: fix duplicated events on check scheduling logic for new events (Andreas Ericsson) #2676 #2993
previously, the logic on scheduling a new event was changed using the
new_event attribute. the decision for actually scheduling a new event
now happens generalized after having decided to actually do so.
furthermore next_check_event is correctly assigned to that new event for
the host|service check (which is a bug in previous versions, causing
duplicate events under different circumstances).
refs #2676
refs #2993
Conflicts:
Changelog
core: avoid duplicate events when scheduling forced host|service check (Imri Zvik) #2993
previously, we had introduced a hash-like implementation of
host|service->next_check_event directly pointing to the next
scheduled event. this algorithm is being used within
schedule_host|service_check, determing wether to use the
already assigned event, or scheduling a new event. Since we
did not populate the event_data (host or service object) when
adding a new event to the scheduler, this became insame, always
rescheduling a new event, but not discarding the old one.
This has been partly fixed in #2676 with refactoring that detection
and saving the next_check_event accordingly. But on already scheduled
events which were forced (overridden), another bug was unveiled.
Now that we add the reverse pointer from the host|service event_data
back to the newly created event when forcing a check, we will make sure
that those events are checked correctly, and executed/discarded in the
first place, and not always creating a new event, seperated from the rest.
basically, using the previous implementation (with and without the fix
from #2676) we've created an event bomb under various circumstances,
especially when future events would have been overridden (forced checks).
as events usually result in checks, which can result into perfdata, this
could possibly the root cause for #2924 as well, as other users reported
on the portal as well.
http://www.monitoring-portal.org/wbb/index.php?page=Thread&threadID=26352
With the kind patch provided by Imri Zvik, this now works like expected.
Adapted the debug output a bit myself, so with debug_level=272 it will be
easy to see what happens on events scheduling - and not the non-telling
mess before.
kudos to Imri Zvik for the patch.
refs #2993
refs #2676
refs #2182
refs #2924
core: avoid duplicate events when scheduling forced host|service check (Imri Zvik) #2993
previously, we had introduced a hash-like implementation of
host|service->next_check_event directly pointing to the next
scheduled event. this algorithm is being used within
schedule_host|service_check, determing wether to use the
already assigned event, or scheduling a new event. Since we
did not populate the event_data (host or service object) when
adding a new event to the scheduler, this became insame, always
rescheduling a new event, but not discarding the old one.
This has been partly fixed in #2676 with refactoring that detection
and saving the next_check_event accordingly. But on already scheduled
events which were forced (overridden), another bug was unveiled.
Now that we add the reverse pointer from the host|service event_data
back to the newly created event when forcing a check, we will make sure
that those events are checked correctly, and executed/discarded in the
first place, and not always creating a new event, seperated from the rest.
basically, using the previous implementation (with and without the fix
from #2676) we've created an event bomb under various circumstances,
especially when future events would have been overridden (forced checks).
as events usually result in checks, which can result into perfdata, this
could possibly the root cause for #2924 as well, as other users reported
on the portal as well.
http://www.monitoring-portal.org/wbb/index.php?page=Thread&threadID=26352
With the kind patch provided by Imri Zvik, this now works like expected.
Adapted the debug output a bit myself, so with debug_level=272 it will be
easy to see what happens on events scheduling - and not the non-telling
mess before.
kudos to Imri Zvik for the patch.
refs #2993
refs #2676
refs #2182
refs #2924
Conflicts:
Changelog
This issue has been migrated from Redmine: https://dev.icinga.com/issues/2676
Created by mfriedrich on 2012-06-11 15:39:04 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2012-08-25 13:35:55 +00:00)
Target Version: 1.7.2
Last Update: 2012-08-25 13:35:55 +00:00 (in Redmine)
from the 1.7 released new_event "hash" logic, a replacement patch, origin nagios svn, andreas ericsson. needs proper analysis and discussion, next to tests.
Attachments
Changesets
2012-07-06 11:21:41 +00:00 by mfriedrich be88bd5
2012-08-18 14:37:52 +00:00 by mfriedrich 379b712
2012-08-19 17:09:21 +00:00 by mfriedrich ec9c5e3
2012-08-19 17:29:57 +00:00 by mfriedrich f32fbf8
Relations:
The text was updated successfully, but these errors were encountered: