[dev.icinga.com #2354] change idomod extension from .o to .so, make .so the default extension for modules

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2354

Created by mfriedrich on 2012-02-24 12:31:55 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-03-16 14:11:54 +00:00)
Target Version: 1.7
Last Update: 2012-03-16 14:11:54 +00:00 (in Redmine)

---

given that #2346 introduced a location change of idomod.o we should take care of one more problem we are keeping for a long time now.

recently, we learned that solaris compilers do not like the .o extension in #524

furthermore, the most common practice is to name it ".so" and put that into the lib dir, as suggest in #2346 and #2347

and we already make packagers aware of a change of idomod.o in #2350

and last but not least, the rhel/fedora bug requires a refreshnment before hitting upstream.
https://bugzilla.redhat.com/show\_bug.cgi?id=693608

so, conclusion to that - change the extension and make packagers aware of that.

Changesets

2012-02-24 17:27:21 +00:00 by mfriedrich d2366ac

install: change idomod extension from .o to .so, make .so the default extension for modules #2354

refs #2354
refs #524
refs #2346

2012-02-25 12:15:17 +00:00 by mfriedrich 15c127e

Merge branch 'test/core' into dev/core

special note:
changes in Makefile to build .so modules instead of .o are already
applied for #1772 / #1253 for both, idomod and helloworld in dev/ido.

test/core contains a full next merge sourced from test/ido -> dev/ido

refs #2354

Conflicts:
	Changelog
	icinga.spec
	module/Makefile.in
	module/idoutils/src/Makefile.in

2012-04-30 14:58:11 +00:00 by mfriedrich 732cf30

core/idomod: add nebmodule version/name check for idomod within core, set module info in idomod, deny to load old idomod.o #2354 #2569

first off, this will deny and unload modules named "idomod.o" as we have
in 1.6.x
furthermore, the newly introduced 1.7.0 idomod neb module will export
its name plus version with neb_set_module_info. this information can be
parsed from the core after calling nebmodule_init and will allow us to
check the idomod version a bit after being loaded (this might already
connect to ido2db, but we can't get any sooner there). if the idomod
version does not match the core's version, the neb module loader will
bail out. this adds more or less the same version dependency as the
packages do already. could be lowered to minimum version requirements
somehow as well, if idomod_version == icinga_version is set too hard.

refs #2354
refs #2569

---

Relations:

• relates #524
• relates #2346
• relates #2347
• relates #2350
• relates #1772
• relates #2354

[icinga-migration]

Updated by mfriedrich on 2012-02-24 16:50:10 +00:00

requires helloworld.o => helloworld.so change.

furthermore, delete the module/idoutils/config/icinga.cfg.in because this is never installed and confuses users - with the changed module.

finally, the contrib/solaris patch from #524 can be dropped as well.

[icinga-migration]

Updated by mfriedrich on 2012-02-24 16:55:44 +00:00

• Subject changed from _change idomod extension from .o to .so _ to change idomod extension from .o to .so, make .so the default extension for modules

[icinga-migration]

Updated by mfriedrich on 2012-02-24 17:09:49 +00:00

/usr/bin/install -c -m 774 -o icinga -g icinga idomod.so /usr/local/icinga/lib

[icinga-migration]

Updated by Tommi on 2012-02-24 19:06:26 +00:00

changes in Makefile to build .so modules instead of .o are already applied for #1772 / #1253 for both, idomod and helloworld in dev/ido.

helloworld.o: helloworld.c
        $(CC) $(MOD_CFLAGS) $(CFLAGS) -o helloworld.so helloworld.c $(MOD_LDFLAGS) $(LDFLAGS) $(LIBS)
        mv helloworld.so helloworld.o

only the mv needs to be removed to fullfill this step.

[icinga-migration]

Updated by mfriedrich on 2012-02-24 19:10:45 +00:00

crap. that's a different dev stage. i'll try merge next into test/core when i'm done fixing the spec file for recent changes.

[icinga-migration]

Updated by mfriedrich on 2012-02-25 12:23:19 +00:00

• Status changed from Assigned to Feedback

ran into that while creating same levels.

the changes live in dev/core currently, and will be merged when everythings tested fine.

[icinga-migration]

Updated by mfriedrich on 2012-03-04 12:38:42 +00:00

• Done % changed from 0 to 100

[icinga-migration]

Updated by mfriedrich on 2012-03-16 14:11:54 +00:00

• Status changed from Feedback to Resolved