Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #2233] icinga.site.xml overwritten by make upgrade #648

Closed
icinga-migration opened this issue Jan 2, 2012 · 9 comments
Closed
Labels
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2233

Created by ralfk on 2012-01-02 09:48:20 +00:00

Assignee: mhein
Status: Resolved (closed on 2012-01-26 11:32:24 +00:00)
Target Version: 1.6.2
Last Update: 2012-02-14 16:40:40 +00:00 (in Redmine)


A make upgrade overwrites the file /usr/local/icinga-web/app/config/icinga.site.xml. All other site.xml files (like factories.site.xml and settings.site.xml) are kept.

Changesets

2012-01-26 10:43:29 +00:00 by mhein 39e8ae3

* Fixed configuration chaos (fixes #2233)
* Fixed logout redirect if no HTTP_Basic (fixes #1005)
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-01-02 09:56:01 +00:00

  • Status changed from New to Feedback

app/config/ is the wrong location for upgrade safe configs - like described on the docs, use /etc/conf.d (or /etc/icinga-web if using a selfbuilt rpm)

http://docs.icinga.org/latest/en/upgrading\_icingaweb.html

as of icinga web 1.5.x

@icinga-migration
Copy link
Author

Updated by ralfk on 2012-01-02 10:39:38 +00:00

Hm, but the docs still describe the site.xml files and it's not stated that they are not supported any more: (http://docs.icinga.org/latest/en/upgrading\_icingaweb.html)

if you stored your customised configuration in *.site.xml- Files, they won't be overwritten during the upgrade process!

And especially the icinga.site.xml files is still included by app/config/settings.xml. So, in fact it is still used, and as long as it is used it should not be overwritten, IMHO.

The docs also say that (only?) the config files of app/modules/Appkit(/Cronks/Web)/config/ have been moved to etc/conf.d (http://docs.icinga.org/latest/en/icinga-web-config.html). So, what about app/config/?

Question: How is the process of reading config files in etc/conf.d ? Are all .xml files read and considered as config files? Or do I need to include those files somewhere (like it was for the outdated site.xml files included like <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="icinga.site.xml">)?

In general I feel that all the config parameters in various XML files are still more confusing than helping. I personally would consider to switch to non-XML config files. Or consolidate the files to really one place (dir).

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-01-02 11:20:50 +00:00

i'd say, this note is sufficient to remark that .site.xml is deprecated.

Please note that there were some major changes starting with Icinga 1.5 that may require some additional actions:

The *.site.xml files for local configuration changes were removed, configurations are now in etc/conf.d/ (or defined during installation with --with-conf-folder

@icinga-migration
Copy link
Author

Updated by ralfk on 2012-01-02 11:38:57 +00:00

Ok, let's confirm that it is not supported any more.

But how to migrate parameters from app/config/icinga.site.xml to the new config dir? By just copying the file to etc/conf.d/ as etc/conf.d/icinga.xml ? See my question in post #2.

Thanks
Ralf

@icinga-migration
Copy link
Author

Updated by mhein on 2012-01-20 10:53:18 +00:00

  • Status changed from Feedback to New
  • Target Version set to 1.7

We will be creating a new icinga.xml in etc/conf.d to allow overwriting settings like app title.

@icinga-migration
Copy link
Author

Updated by mhein on 2012-01-26 08:49:20 +00:00

  • Assigned to set to mhein

@icinga-migration
Copy link
Author

Updated by mhein on 2012-01-26 11:32:24 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 39e8ae3.

@icinga-migration
Copy link
Author

Updated by mhein on 2012-01-26 11:32:52 +00:00

Okay, new scheme is this:

https://wiki.icinga.org/display/Dev/Icinga-Web+-+XML+configuration

Hope this helps

@icinga-migration
Copy link
Author

Updated by mhein on 2012-02-14 16:40:40 +00:00

  • Target Version changed from 1.7 to 1.6.2

@icinga-migration icinga-migration added this to the 1.6.2 milestone Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant