[dev.icinga.com #2181] change varchar(255) to TEXT in mysql #816
Comments
Updated by mfriedrich on 2012-01-27 20:39:06 +00:00
|
Updated by mfriedrich on 2012-04-03 12:06:12 +00:00
before changing this, more feedback is required. |
Updated by Tommi on 2012-04-04 19:02:48 +00:00 should be possible. So far i can see are 8 tables affected. In oracle output field is already extended to 2048 Bytes. mysql type text means 65k. if it should be equalized with long_output, then we can think about why we need an output and a long output column, if the size is the same. Searching in bigger fields might be slower, espially in LOBS in oracle. For this exists a special oracle option "Oracle Text", which adds full text search to the DB (and requires propretary sql syntax). Dont know if there is similar in pgsql and mysql. |
Updated by mfriedrich on 2012-04-25 10:46:49 +00:00 affects other varchar limits as well - mostly those with 255 letters. |
Updated by mfriedrich on 2012-04-25 15:50:34 +00:00
this should not harm performance that much, and can be a nice addin for 1.7 as change everything release. |
Updated by mfriedrich on 2012-04-25 16:00:43 +00:00 latin1_general_cs varchars will remain, like display_name and name1/2, otherwise selects won't work case sensitive. |
Updated by mfriedrich on 2012-04-25 16:11:20 +00:00 contacts.email_address is left 255 chars, there's an rfc for that. |
Updated by mfriedrich on 2012-04-25 16:37:13 +00:00
|
Updated by melle on 2012-04-26 11:32:09 +00:00
|
Updated by mfriedrich on 2012-04-26 11:49:17 +00:00 hmm thanks for the feedback. where would you put that change message? it's already within the Changelog itsself .. make install-idoutils ? |
Updated by melle on 2012-04-26 12:04:22 +00:00 I noticed this quite important change only by lurking through the changelog out of curiosity, yes. I would not have noticed this when performing a "standard" upgrade, as I do not often look through the changelog at all. I second your idea showing a message after invoking "make install-idoutils", as at this point people are expecting problems or hints to show up. Another option would be deleting or moving bin/idomod.o and symlinking lib/idomod.so to bin/idomod.o, so no config change would be required. But I assume this is bad practice in full glory :-) |
Updated by mfriedrich on 2012-04-26 12:16:40 +00:00 see #2558 the change will look like this now for 1.7 (soon to be pushed to git)
|
Updated by melle on 2012-04-26 12:35:00 +00:00 Be sure to not lose any letters in the makefile output by accidentially escaping them (see "ibdir", "indir" above :-D) But besides this minor cosmetic issue - great work! |
Updated by mfriedrich on 2012-04-26 12:37:15 +00:00
yep, i will tell about that further in #2558 |
Updated by mfriedrich on 2012-04-27 08:16:18 +00:00
that will not work. mysql cannot garantuee the uniqueness for the index of the first N entries of a TEXT value, but requires either a drop of the unique constraint, or a fallback to varchar again. telling TEXT (255) will not work, sadly.
|
Updated by mfriedrich on 2012-04-27 08:17:06 +00:00
|
Updated by mfriedrich on 2012-04-27 08:34:39 +00:00 http://dev.mysql.com/doc/refman/5.1/en/char.html
|
Updated by mfriedrich on 2012-04-27 10:54:43 +00:00
Applied in changeset 0b9ef1a. |
Updated by mfriedrich on 2012-05-01 16:05:36 +00:00
some more unique keys cause failures. |
Updated by mfriedrich on 2012-05-01 17:36:09 +00:00
|
Updated by mfriedrich on 2014-12-08 14:46:29 +00:00
|
Updated by mfriedrich on 2016-07-07 16:33:42 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/2181
Created by mfriedrich on 2011-12-12 13:54:51 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2012-05-01 17:36:09 +00:00)
Target Version: 1.7
Last Update: 2014-12-08 14:46:29 +00:00 (in Redmine)
varchar(255) might be less than demanded and therefore the column should be changed to text, same as longoutput and perfdata.
related to #2131
Changesets
2012-04-25 16:21:07 +00:00 by mfriedrich df4ef62
2012-04-27 09:16:29 +00:00 by mfriedrich 0b9ef1a
2012-05-01 14:31:07 +00:00 by mfriedrich 07d4985
2012-05-01 16:13:19 +00:00 by mfriedrich 275664f
Relations:
The text was updated successfully, but these errors were encountered: