You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Created by mfriedrich on 2011-10-21 18:31:56 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2011-10-21 19:31:42 +00:00)
Target Version: 1.6
Last Update: 2011-12-03 11:30:20 +00:00 (in Redmine)
sourcing from #1744 it came up that the macro $NOTIFICATIONRECIPIENTS$ is populated wrong.
everytime, add_notification is called, a new entry is also added to that macro. so even when adding a contact to the notification list and not notifying afterwards due to the viability checks left the entry in there.
by moving the viability checks before even adding a contact to the notification list, that macro is not populated too and remains clean.
* core: reduce notification load by moving notification viability check into notification list creation #1744 ; fix $NOTIFICATIONRECIPIENTS$ macro contains all contacts assigned to host|service, not only notified contacts #2023
two in one. please check the dev tracker issues
for a deeper analysis.
https://dev.icinga.org/issues/1744
https://dev.icinga.org/issues/2023
kudos to Opsview Team for their initial patch, now reworked
against local macros, added inline comments to the code too.
refs #1744
refs #2023
This issue has been migrated from Redmine: https://dev.icinga.com/issues/2023
Created by mfriedrich on 2011-10-21 18:31:56 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2011-10-21 19:31:42 +00:00)
Target Version: 1.6
Last Update: 2011-12-03 11:30:20 +00:00 (in Redmine)
sourcing from #1744 it came up that the macro$NOTIFICATIONRECIPIENTS$ is populated wrong.
everytime, add_notification is called, a new entry is also added to that macro. so even when adding a contact to the notification list and not notifying afterwards due to the viability checks left the entry in there.
by moving the viability checks before even adding a contact to the notification list, that macro is not populated too and remains clean.
this sources from this nagios bug - http://tracker.nagios.org/view.php?id=98
and can be resolved hand in hand while improving performance on the notifications overall.
Changesets
2011-10-21 19:17:23 +00:00 by mfriedrich 365574b
Relations:
The text was updated successfully, but these errors were encountered: