$NOTIFICATIONRECIPIENTS$ macro contains all contacts assigned to host|service, not only notified contacts
|Target version:||Icinga 1.x - 1.6|
|Icinga Version:||OS Version:|
sourcing from #1744 it came up that the macro $NOTIFICATIONRECIPIENTS$ is populated wrong.
everytime, add_notification is called, a new entry is also added to that macro. so even when adding a contact to the notification list and not notifying afterwards due to the viability checks left the entry in there.
by moving the viability checks before even adding a contact to the notification list, that macro is not populated too and remains clean.
this sources from this nagios bug - http://tracker.nagios.org/view.php?id=98
and can be resolved hand in hand while improving performance on the notifications overall.
- core: reduce notification load by moving notification viability check into notification list creation #1744 ; fix $NOTIFICATIONRECIPIENTS$ macro contains all contacts assigned to host|service, not only notified contacts #2023
two in one. please check the dev tracker issues
for a deeper analysis.
kudos to Opsview Team for their initial patch, now reworked
against local macros, added inline comments to the code too.