[dev.icinga.com #2018] make nostatusheader in status.cgi a config option

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2018

Created by stku on 2011-10-17 13:09:45 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-04-13 19:03:42 +00:00)
Target Version: 1.7
Last Update: 2014-12-08 09:32:49 +00:00 (in Redmine)

---

Hello, for my point it is not a good idea to disable statusheader in status.cgi. Without the statusheader I can not filter in my Host- and Servicegroups for Problems. With the new TAC Header I can only filter for all Problems not for Service- or Hostgroups. This function is very important for large installations to get a better overview.

Changesets

2011-12-17 12:16:51 +00:00 by ricardo 614c0c3

classic-ui: Added config option for status totals in status.cgi #2018

refs: #2018

* added config option
* removed 'nostatusheader' from all urls

2012-01-02 23:28:09 +00:00 by ricardo 6c8e32b

classic ui: Added multiple hosts/services to status.cgi GET #1981

refs: #1524
refs: #1981
refs: #2018
refs: #2173
refs: #2220

This is pretty much a rewrite of status.cgi.

some changes:
* you can define more then one object to display
** host=hostA&host=hostB&host=…
** same with host groups and service groups
* hostgroup=all now only shows which are in host groups
* host sorting is working now
* added 2 new cgi vars
** sortobject = determine if to sort host or service list (host_service_view)
** allunhandledproblems = to display ALL unhanded problems
* fixed and reorganized the links in status totals
* searching returns more then one host/service group if group name matches
* combined Host/Service view now properly supported
* code cleanup
* more little fixes and enhancements

2012-01-04 22:38:39 +00:00 by ricardo 9491141

classic ui: correcting urls for status.cgi

refs: #1981
refs: #2018

2012-04-13 18:48:07 +00:00 by ricardo 7b9ec5b

classic-ui: updated Changelog CHANGES section

refs: #1524
refs: #1981
refs: #2018
refs: #2117
refs: #2119
refs: #2145
refs: #2198
refs: #2343
refs: #2359
refs: #2373
refs: #2421

hope the "changes" section for classic ui isn't tooo long

---

Relations:

• relates #2018
• relates #2018

[icinga-migration]

Updated by mfriedrich on 2011-10-17 13:15:59 +00:00

• Status changed from New to Feedback

the status header is not fully disabled, it's just &nostatusheader as GET param within the url, embedding it into the new tac header interface.

if you intend to propose more filters for it, feel free. but the hidden status totals is intended for smaller displays, adding more space for the important information.

[icinga-migration]

Updated by stku on 2011-10-17 13:29:25 +00:00

To change it in menue.html it is not a problem but also in the cgi's the &nostatusheader is set. To enable it I have to recompile the cgi's. To have a smaller header I think it will be better to do it like the Display Filters with the small '+'.

[icinga-migration]

Updated by mjbrooks on 2011-10-26 07:29:13 +00:00

The new TAC Header doesn't take any more space than what was taken by the empty graphic section it replaced, so I'm not sure how the concern for space came about.

The interface tests fine on 1024x768 with the statusheader. Since 1024x768 is today's current standard benchmark for designing web pages, anyone who is trying to use Icinga on less than that should probably focus on dealing with their lack of having hardware that could be had for a dime a dozen even as far back as the 1990s.

That said, the TAC Header is meant to give a global view of things so if you happen to be looking at some detail somewhere you can still see a new event come in, but it isn't a replacement for the statusheader which as I recall, break things down nicely by service and host groups.

dnsmichi: I'm not sure what you mean by "embedding it into the new tac header interface". The tac header is descended from tac.cgi and knows nothing of status.cgi or of the existence or state of &nostatusheader status.cgi takes.

We shouldn't sacrifice giving everyone this very important finer view because a handful of people can't/won't upgrade their monitor to at least 1024x768.

At least that's my $0.02.

Commit ef5555d should probably not have happened or at the very least been designed to depend on a cgi.cfg option or as stku said, have it collapsed and expandable like how the display filters work.

[icinga-migration]

Updated by mfriedrich on 2011-10-26 09:34:41 +00:00

mjbrooks wrote:

The new TAC Header doesn't take any more space than what was taken by the empty graphic section it replaced, so I'm not sure how the concern for space came about.

the discussion is not about the new tac header. it's about the removal of the now unnecessary "host|service status totals" on every cgi page - at least in the opinion of myself and my co-workers.

embedding a cgi into the current frameset (with tac header and menu html) just would give you duplicated information at the cost of at least 5 lines of html (if the display_info_table would have stayed the same and was not cut by myself too).
maybe mebedding is the wrong wording, let's say "include".

dnsmichi: I'm not sure what you mean by "embedding it into the new tac header interface". The tac header is descended from tac.cgi and knows nothing of status.cgi or of the existence or state of &nostatusheader status.cgi takes.

sure it doesn't. but it creates an overview which is basically the same, but calculated in a different position in the code. so this is made a duplicate in my opinion, when using the frameset.

We shouldn't sacrifice giving everyone this very important finer view because a handful of people can't/won't upgrade their monitor to at least 1024x768.

actually this "finer" view has a lot of bugs, i.e. searching with a regular expression makes the counting 0. so until the bugs on the status totals are not fully resolved and give a proper correct view on the things happening, i don't see any reason to keep it here.
this goes hand in hand with designing new filters on the status pages and so on.

Commit ef5555d should probably not have happened or at the very least been designed to depend on a cgi.cfg option or as stku said, have it collapsed and expandable like how the display filters work.

well actually it happened because i designed it that way, keeping up with the demands in the space problems. if you really see a problem with the nostatusheader being added within C code, then make it a config option so that all embedded urls in C code could be revoked to the old style.
i thought about that while adding this opportunity, but as you can see, due to code mangeling and possible unreadable sections i did not. anyhow, if you keep up with this, allow users to re-enable the status totals on the status.cgi but do not change the released default by now. i already got people working with the revamped view and upgrade changes will make them and me unhappy.

[icinga-migration]

Updated by ricardo on 2011-11-05 16:35:54 +00:00

• Subject changed from nostatusheader in all URLs to status.cgi to make nostatusheader in status.cgi a config option

we should change this into a config option.

after #1524 is fixed all status counts should be right.

[icinga-migration]

Updated by ricardo on 2011-12-16 22:24:57 +00:00

• Assigned to set to ricardo
• Target Version set to 1.7
• Done % changed from 0 to 90

Added config option "display_status_totals" to cgi.cfg

Please TEST!!!

[icinga-migration]

Updated by mfriedrich on 2011-12-17 01:08:05 +00:00

you can't drop nostatusheader as url GET option. this is being used by various people in production. you can still make this an empty string if ppl want to really disable its usage.

[icinga-migration]

Updated by ricardo on 2011-12-17 12:20:15 +00:00

Thanks for testing.

fixed!

[icinga-migration]

Updated by mfriedrich on 2011-12-17 12:58:17 +00:00

hmmm where? i only see the exact same commit in git.

[icinga-migration]

Updated by ricardo on 2011-12-17 13:26:10 +00:00

have you tested it?

nostatusheader still works!!1

[icinga-migration]

Updated by mfriedrich on 2011-12-18 10:57:21 +00:00

no, i did not test it. i was just reading the git diffs until i get my test boxes again.

[icinga-migration]

Updated by mfriedrich on 2012-04-03 14:06:07 +00:00

• Done % changed from 90 to 100

setting display_status_totals=1 enables that, otherwise everything won't show the statustotals.

[icinga-migration]

Updated by ricardo on 2012-04-13 14:40:26 +00:00

should be ready to go

[icinga-migration]

Updated by ricardo on 2012-04-13 19:03:42 +00:00

• Status changed from Feedback to Resolved

Added note to changes in Changelog

[icinga-migration]

Updated by mfriedrich on 2014-12-08 09:32:49 +00:00

• Project changed from 19 to Core, Classic UI, IDOUtils
• Category set to Classic UI