Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #1951] Move search to menubar #525

Closed
icinga-migration opened this issue Sep 26, 2011 · 8 comments
Closed

[dev.icinga.com #1951] Move search to menubar #525

icinga-migration opened this issue Sep 26, 2011 · 8 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1951

Created by jmosshammer on 2011-09-26 13:13:00 +00:00

Assignee: mhein
Status: Resolved (closed on 2011-11-18 12:44:43 +00:00)
Target Version: 1.6
Last Update: 2011-12-03 11:30:17 +00:00 (in Redmine)


  • Move Search to a IcingaSearchbar component
  • registerSearchHandler() registers a search function
  • if no search function is registered, the searchbar is hidden

Changesets

2011-09-30 14:10:42 +00:00 by mhein 74b876c

* Implemented new search method (fixes #1951)
@icinga-migration
Copy link
Author

Updated by jmosshammer on 2011-09-26 15:32:57 +00:00

  • Subject changed from Move search to bar to Move search to menubar

@icinga-migration
Copy link
Author

Updated by mhein on 2011-09-27 11:31:03 +00:00

  • Estimated Hours set to 10
  • Also add an autocompletion handler (url or something)

@icinga-migration
Copy link
Author

Updated by mhein on 2011-09-28 13:46:29 +00:00

  • Assigned to set to mhein

@icinga-migration
Copy link
Author

Updated by mhein on 2011-09-30 14:12:51 +00:00

  • Status changed from New to Resolved

Implemented:

  • New searchbox on top
  • Global handler to register search actions
  • Removed cronk portal from inline template into seperate file
  • Added cronk search handler with the common window

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-10-22 20:21:36 +00:00

  • Status changed from Resolved to Feedback

i've just tested that with iceweasel 7.0.1 and ctrl+alt+f does not open the search window, only when hovering the mosue over the search icon, it brings up a new search window.

current git master

$ git log -1
commit 60615ba80e56ad97fc625fd2c1ac641301d4f1df
Merge: 335fd31 ded0ac4
Author: Jannis Moßhammer 
Date:   Fri Oct 21 18:45:56 2011 +0200

    Merge branch 'master' of ssh://git.icinga.org/icinga-web

@icinga-migration
Copy link
Author

Updated by jmosshammer on 2011-10-22 20:42:38 +00:00

I don't think this was planned as a shortcut - the old version didn't have this either.

As ctrl-alt-f is a browser feature for full-text search on the current page, I wouldn't override this behaviour for view specific searches in icinga-web (or a module). When I use ctrl-alt-f, i'm searching text on site, and not a logical entity that could be viewed in the application.

@icinga-migration
Copy link
Author

Updated by jmosshammer on 2011-11-18 12:44:43 +00:00

  • Status changed from Feedback to Resolved

forget it - i meant strg-f....

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-12-03 11:30:17 +00:00

  • Done % changed from 0 to 100

@icinga-migration icinga-migration added this to the 1.6 milestone Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant