Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #1648] Use core.app_name instead of 'Icinga' #431

Closed
icinga-migration opened this issue Jun 15, 2011 · 3 comments
Closed
Labels
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1648

Created by tgelf on 2011-06-15 09:23:53 +00:00

Assignee: mhein
Status: Resolved (closed on 2011-08-23 10:32:09 +00:00)
Target Version: 1.5
Last Update: 2011-08-23 10:32:09 +00:00 (in Redmine)


There is app_name to be found in settings.xml, however it isn't respected everywhere. It should be added in at least to places:

app/modules/Cronks/templates/System/PortalHelloSuccess.php:

Welcome to Icinga (... +

Welcome to (...

app/modules/Cronks/lib/js/CronkTabpanel.js

  • document.title = "Icinga - "...
  • document.title = Whatever.config.get('app_name', 'Icinga') + " - "...

However, there is nothing like a Whatever.config.get(key, default) yet. IMO app_name but also version information and others shall somehow be made available to JS scripts.

Changesets

2011-08-23 10:30:52 +00:00 by mhein 9800229

* Configurable app name (fixes #1648)

@icinga-migration
Copy link
Author

Updated by tgelf on 2011-06-15 09:26:07 +00:00

There is another "Icinga" in PortalHelloSuccess.php - it should read '...widgets for the $app_name web front end...'

@icinga-migration
Copy link
Author

Updated by mhein on 2011-08-23 09:55:50 +00:00

  • Assigned to set to mhein
  • Target Version set to 1.5

@icinga-migration
Copy link
Author

Updated by mhein on 2011-08-23 10:32:09 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 9800229.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant