[dev.icinga.com #1513] Prefs growing endlessly in Icinga-Web causing lot's of traffic

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1513

Created by tgelf on 2011-05-13 11:24:19 +00:00

Assignee: (none)
Status: Closed (closed on 2011-05-18 06:21:03 +00:00)
Target Version: 1.5
Last Update: 2011-05-18 06:21:03 +00:00 (in Redmine)

---

Icinga-Web issues applicationState POSTs resulting in pretty large replies after being in use a short while. You can easily reproduce this on http://web.demo.icinga.org/: open Firebug and switch to another already opened tab. It should look similar to the attached screenshot appstate.png.

You can find a quick and dirty patch attached to this issue. It does the config merge in a way fitting the given data structure. At least that's how I believe it has been thought to work.

At a test site this patch has reduced the average profile size from 1-6 megs to a very few kB.

Regards,
Thomas

Attachments

• appstate.png tgelf - 2011-05-13 11:24:19 +00:00
• icinga-web_amokprefs.patch tgelf - 2011-05-13 11:24:19 +00:00
• icinga-web_amokprefs.patch tgelf - 2011-05-13 15:10:27 +00:00
• icinga-web_amokprefs.patch tgelf - 2011-05-13 15:23:45 +00:00

[icinga-migration]

Updated by tgelf on 2011-05-13 11:29:11 +00:00

Please note that this patch automagically fixes existing zombie profiles. After the first applicationState POST each user shall have a cute small appstate pref - and much less traffic.

[icinga-migration]

Updated by tgelf on 2011-05-13 15:10:27 +00:00

• File added icinga-web_amokprefs.patch

New version of the same patch: tabs VS spaces.

[icinga-migration]

Updated by tgelf on 2011-05-13 15:23:45 +00:00

• File added icinga-web_amokprefs.patch

It's friday afternoon :p

[icinga-migration]

Updated by tgelf on 2011-05-13 15:31:54 +00:00

NB: Please also check whether it is required to answer with full prefs to an applicationState POST.

[icinga-migration]

Updated by jmosshammer on 2011-05-16 11:48:15 +00:00

• Target Version changed from 1.4 to 1.5

[icinga-migration]

Updated by tgelf on 2011-05-16 16:55:18 +00:00

The patch is not perfect yet, even if it improved things a lot. Already closed cronks will still remain in your prefs blob. The correct approach would probably be looping over all dynamic cronks (cronk-sid\d+ ?) and compare their id with those still to be found in cronk-tab-panel.

Please also check whether portal views need special care or not.

[icinga-migration]

Updated by mhein on 2011-05-17 12:53:27 +00:00

• Target Version deleted 1.5

[icinga-migration]

Updated by mhein on 2011-05-17 12:56:51 +00:00

• Target Version set to 1.5

[icinga-migration]

Updated by jmosshammer on 2011-05-18 06:21:03 +00:00

• Status changed from New to Closed

fixed in master commit: fe60941