Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #1508] counting for services in tac header is wrong #628

Closed
icinga-migration opened this issue May 12, 2011 · 9 comments
Closed

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1508

Created by ricardo on 2011-05-12 11:07:47 +00:00

Assignee: ricardo
Status: Resolved (closed on 2011-06-07 14:36:56 +00:00)
Target Version: 1.4.1
Last Update: 2014-12-08 09:42:14 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

the problem here is that also problems from hosts which are down/unreachable are also get counted.

Changesets

2011-05-12 22:40:31 +00:00 by ricardo 8bc8772

fixing tac.cgi header problems with counting and adding pending and descritptions #1508

refs #1508
refs #1506
refs #1505

2011-05-16 09:47:47 +00:00 by (unknown) 0126dd4

Additional corrections to tac header counts #1508

This corrects the corrections made by rbartels to the tac header
counts in commit 8bc877224fb82a78f8f8e9ca43ec3805b2c7ca58

It adds additional service_*_unacknowledged_hosts_down ints and
takes them into account in the display of the service counts.

It also makes the display of pending states that Ricardo included
with his chages in the tac header a cgi.cfg option that is off by
default.

The count entries in the tac header begin to lose room and may wrap
for users if they have a display that is <1024x768 when the pending
entries are included. That was the primary reason why I didn't
include them originally. However, since Ricardo made the effort
to add them and those with larger screens may find them useful, I
felt this would be a reasonable compromise.

refs #1508
refs #1506
refs #1505

2011-05-19 18:58:56 +00:00 by ricardo 1ce1af3

corrected behaviour of pending states in tac header #1508

refs: #1508

hope the issue is finally resolved with this commit.

2011-06-04 09:47:30 +00:00 by ricardo 6afa0b5

fixing tac.cgi header problems with counting and adding pending and descritptions #1508

refs #1508
refs #1506
refs #1505

2011-06-04 09:47:56 +00:00 by (unknown) 62dd181

Additional corrections to tac header counts #1508

This corrects the corrections made by rbartels to the tac header
counts in commit 8bc877224fb82a78f8f8e9ca43ec3805b2c7ca58

It adds additional service_*_unacknowledged_hosts_down ints and
takes them into account in the display of the service counts.

It also makes the display of pending states that Ricardo included
with his chages in the tac header a cgi.cfg option that is off by
default.

The count entries in the tac header begin to lose room and may wrap
for users if they have a display that is <1024x768 when the pending
entries are included. That was the primary reason why I didn't
include them originally. However, since Ricardo made the effort
to add them and those with larger screens may find them useful, I
felt this would be a reasonable compromise.

refs #1508
refs #1506
refs #1505

2011-06-04 09:49:15 +00:00 by ricardo 2c52754

corrected behaviour of pending states in tac header #1508

refs: #1508

hope the issue is finally resolved with this commit.
@icinga-migration
Copy link
Author

Updated by ricardo on 2011-05-12 22:51:54 +00:00

  • Status changed from New to Feedback
  • Assigned to set to ricardo
  • Done % changed from 0 to 100

counting should be fine by now, except services total will be off when you have pending services on down hosts.

@icinga-migration
Copy link
Author

Updated by mjbrooks on 2011-05-13 01:10:08 +00:00

I'm pulling in your branch to look at now. But from the looks of the demo system you get a +1 Excellent ;)

@icinga-migration
Copy link
Author

Updated by mjbrooks on 2011-05-13 04:33:23 +00:00

A cfg option to not have the pending tags displayed would be nice. They are of limited use in day to day operations for most people. Just a thought.

Great work BTW!

@icinga-migration
Copy link
Author

Updated by mjbrooks on 2011-05-16 10:52:06 +00:00

I believe I have the fixes for your 8bc8772 commit, but your branch is tainted by an unrelated change so I'm not sure what the preferred way is of pushing my change to the git server is since now that you're deviated from master.

@icinga-migration
Copy link
Author

Updated by mjbrooks on 2011-05-17 12:25:22 +00:00

Ricardo and I both seem to feel that these commits correct the counting.

Can someone halfway decent at math also confirm? ;)

@icinga-migration
Copy link
Author

Updated by mjbrooks on 2011-05-20 06:00:34 +00:00

  • Target Version changed from 1.5 to 1.4.1

Changing target now that we have a new one to set

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-05-23 17:07:14 +00:00

the unknown count is still buggy, but already told ricardo.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-06-07 14:36:56 +00:00

  • Status changed from Feedback to Resolved

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-08 09:42:14 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • Icinga Version set to 1
  • OS Version set to any

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant