Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13805] Windows Agent: performance data of check_perfmon #4896

Closed
icinga-migration opened this issue Dec 28, 2016 · 8 comments
Labels
area/windows Windows agent and plugins bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13805

Created by mwe on 2016-12-28 07:18:06 +00:00

Assignee: jflach
Status: Assigned (closed on 2017-01-12 15:02:19 +00:00)
Target Version: (none)
Last Update: 2017-01-15 18:50:18 +00:00 (in Redmine)

Icinga Version: 2.6.0
Backport?: Not yet backported
Include in Changelog: 1

The fix for change described in Bug #10489 breaks performance data when using graphite. Current graphite release 0.9.15 cannot deal with special characters like quotes or brackets. Skipping "perfmon" string leads to missing graphite graphs in Icingaweb2 (as you can see in attached image). Also via graphite gui its not possible to add metrics with special graphs.
Solution might be possible in two different approches:

  • change every plugin to deliver valid performance data labels
  • extend graphitewriter.cpp to escape all special chars except allowed chars

Second approach might be easier to use, since you solve to problem for all plugins with one change. graphite release 0.10.0 also has some bugfixes regading rrd paths and special chars in metric names - but there is no estimated relase date right now.

Attachments

Changesets

2017-01-12 14:55:26 +00:00 by jflach 7b2723a

Add --perf-syntax option to check_perfmon

fixes #13805
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2017-01-11 16:50:47 +00:00

  • Status changed from New to Assigned
  • Assigned to set to jflach

The plugins themselves must be fixed to use proper labels.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2017-01-12 12:40:19 +00:00

https://blog.netways.de/2016/04/14/windows-performance-counters-with-nsclient-and-graphite/

@icinga-migration
Copy link
Author

Updated by jflach on 2017-01-12 12:45:38 +00:00

The fix will be a --perf-syntax option akin to that in nscps check_pdh

@icinga-migration
Copy link
Author

Updated by jflach on 2017-01-12 15:02:19 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 7b2723a.

@icinga-migration
Copy link
Author

Updated by jflach on 2017-01-12 15:02:37 +00:00

  • Target Version set to 2.7.0

@icinga-migration
Copy link
Author

Updated by jflach on 2017-01-12 15:14:06 +00:00

  • Status changed from Resolved to Assigned
  • Target Version deleted 2.7.0
  • Done % changed from 100 to 0

whoops!

@icinga-migration
Copy link
Author

Updated by mwe on 2017-01-15 18:50:19 +00:00

That would be a good solution, thanks!

@andrewmooreio
Copy link

Also would be very interested in the --perf-syntax addition.

@Crunsher Crunsher added this to the 2.7.0 milestone Feb 20, 2017
@dnsmichi dnsmichi added the area/windows Windows agent and plugins label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Windows agent and plugins bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants