[dev.icinga.com #13489] Downtime end notified when downtime has been cancelled before starting

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13489

Created by mfrosch on 2016-12-08 15:50:53 +00:00

Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-12-09 10:31:07 +00:00 (in Redmine)

Icinga Version: 2.6.0-dev
Backport?: Not yet backported
Include in Changelog: 1

---

In addition to #12549

When I cancel a downtime that starts in the future, a DOWNTIMEEND notification is send.

[2016-12-08 15:46:22] [test] [test-simple!test-critical] [DOWNTIMEEND] [CRITICAL] CRITICAL: This check is always CRITICAL.
 Author: icingaadmin
 Comment: TEST

Also not sure if the actual dates should be filled for a downtime that never started:

    downtimehistory_id: 2
           instance_id: 1
         downtime_type: 1
             object_id: 235
            entry_time: 2016-12-08 15:42:23
           author_name: icingaadmin
          comment_data: TEST
  internal_downtime_id: 2
       triggered_by_id: 0
              is_fixed: 1
              duration: 0
  scheduled_start_time: 2016-12-09 15:42:12
    scheduled_end_time: 2016-12-09 16:42:12
           was_started: 0
     actual_start_time: 2016-12-09 15:42:12
actual_start_time_usec: 0
       actual_end_time: 2016-12-08 15:46:22
  actual_end_time_usec: 790323
         was_cancelled: 1
          is_in_effect: 0
          trigger_time: NULL
                  name: test-simple!test-critical!master1-1481211743-1
    endpoint_object_id: 174

---

Relations:

• relates #12549

[icinga-migration]

Updated by mfrosch on 2016-12-08 15:51:01 +00:00

• Relates set to 12549

[icinga-migration]

Updated by mfrosch on 2016-12-08 15:52:38 +00:00

• Subject changed from Downtime end notified when downtime has been cancelled to Downtime end notified when downtime has been cancelled before starting

[icinga-migration]

Updated by tgelf on 2016-12-08 16:08:58 +00:00

mfrosch wrote:

Also not sure if the actual dates should be filled for a downtime that never started:

Absolutely not, this is bad for SLA reports.

[icinga-migration]

Updated by mfriedrich on 2016-12-09 10:31:07 +00:00

History views and sla reports should take the "was_cancelled" column into account. That one is updated too. The actual_end_time is updated in Icinga 1.x and so does Icinga 2 to behave the same. Icinga Web 2 doesn't take "was_cancelled" into account currently as far as I can see.

In terms of sending a downtimeend notification - this has been sitting there by design, since the downtime is removed. There's no such different notification flag for cancelled downtimes (yet). Probably we should change that, but I'd like to discuss this with Eric and Gunnar first (which means not something for 2.6).

[dnsmichi]

There's no difference for the notification type here. As said, if this comes into SLA play, ignore everything which is was_cancelled=1.