Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13467] renderLayout has side-effects #2639

Closed
icinga-migration opened this issue Dec 7, 2016 · 3 comments
Closed

[dev.icinga.com #13467] renderLayout has side-effects #2639

icinga-migration opened this issue Dec 7, 2016 · 3 comments
Labels
area/javascript Affects the javascript framework bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13467

Created by tgelf on 2016-12-07 20:59:26 +00:00

Assignee: elippmann
Status: Resolved (closed on 2016-12-12 14:03:32 +00:00)
Target Version: 2.4.0
Last Update: 2016-12-12 14:03:32 +00:00 (in Redmine)


I examined strange layout bugs from time to time, but have never been able to reproduce them. Now I finally caught at least one of them. There are requests asking to re-render the layout (#layout). This has the side-effect that properties that should target a specific container #col1 in that case) will be placed into the #layout tag.

This will have the side-effect of module-styles affecting the whole layout, rendering bugs in the menu and more. Should be fixed by hard-coding that exception to loader.js, making sure that classes like icinga-module, module- and settings related to auto-refresh are placed to #col1 instead of #layout. Please also check whether the same problem exists for data-base-target=_main.

To reproduce this just SHIFT-TAB in the search field and enable (or disable) auto-refresh.

Best,
Thomas

NB: It would be cool if this could make it into the next release ;-)

Changesets

2016-12-12 14:02:51 +00:00 by elippmann e030229

Fix CSS issues when rerendering the layout

fixes #13467
@icinga-migration
Copy link
Author

Updated by elippmann on 2016-12-08 13:34:11 +00:00

  • Status changed from New to Feedback
  • Assigned to set to tgelf

Please share the URL where you experience this issue.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-08 13:39:55 +00:00

  • Status changed from Feedback to Assigned
  • Assigned to changed from tgelf to elippmann

Any URL that belongs to a module, monitoring/list/hosts, whatever. Go there, have a look at the #layout div in your browsers dev tools. Then click to the global search field, SHIFT-Tab, disable auto-refresh, have another look.

@icinga-migration
Copy link
Author

Updated by elippmann on 2016-12-12 14:03:32 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset e030229.

@icinga-migration icinga-migration added bug Something isn't working area/javascript Affects the javascript framework labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.4.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Affects the javascript framework bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant