Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13417] Config validation should check the schema version #4830

Closed
icinga-migration opened this issue Dec 6, 2016 · 3 comments
Labels
area/db-ido Database output enhancement New feature or request

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13417

Created by mfrosch on 2016-12-06 09:26:01 +00:00

Assignee: mfrosch
Status: New
Target Version: (none)
Last Update: 2016-12-08 08:18:47 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

When running Icinga config validation, we should actually check if the IDO connection works (not sure if this is tested now).

But especially we should check if the database schema is correct.

Currently this only bails out on the daemon start, and not on validation.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-12-08 00:24:57 +00:00

I wonder how this should be possible. At config compile time there is no IdoMysqlConnection nor a started object with an active database connection.

@icinga-migration
Copy link
Author

Updated by mfrosch on 2016-12-08 08:18:47 +00:00

mfriedrich wrote:

I wonder how this should be possible. At config compile time there is no IdoMysqlConnection nor a started object with an active database connection.

The same way we should validate if a database connection works.

Would make sense, because your config test says all is fine, but the daemon stops right during startup...

@dnsmichi
Copy link
Contributor

Continue in #4440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-ido Database output enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants