Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13397] OpenSSL 1.1 support for Windows #4822

Closed
icinga-migration opened this issue Dec 3, 2016 · 3 comments
Closed

[dev.icinga.com #13397] OpenSSL 1.1 support for Windows #4822

icinga-migration opened this issue Dec 3, 2016 · 3 comments
Labels
area/windows Windows agent and plugins enhancement New feature or request

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13397

Created by TheFlyingCorpse on 2016-12-03 20:37:33 +00:00

Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-12-03 21:47:22 +00:00 (in Redmine)

Icinga Version: 2.5.4-master
Backport?: Not yet backported
Include in Changelog: 1

Fix the CMakeLists.txt to properly include the correct DLL's for OpenSSL 1.1 when it is present for Windows packages.

Patch incoming, verifying for both 32bit and 64bit.

Attachments

@icinga-migration
Copy link
Author

Updated by TheFlyingCorpse on 2016-12-03 21:45:26 +00:00

  • File added 0004-Use-OpenSSL-1.1-binaries-on-Windows-if-available.patch

Patch is made against current master.
Verified against an icinga2 server using the debian jessie snapshots which uses openssl 1.0.

@icinga-migration
Copy link
Author

Updated by TheFlyingCorpse on 2016-12-03 21:47:22 +00:00

It has been verified on the following OS'es and architectures:

  • Windows 10 64bit
  • Windows Server 2008 R2 64bit
  • Windows Server 2008 32bit

@icinga-migration icinga-migration added the bug Something isn't working label Jan 17, 2017
@Crunsher Crunsher self-assigned this Jan 31, 2017
@gunnarbeutner gunnarbeutner added enhancement New feature or request area/windows Windows agent and plugins and removed bug Something isn't working labels Feb 7, 2017
Crunsher added a commit that referenced this issue Apr 6, 2017
Crunsher added a commit that referenced this issue Apr 6, 2017
@Crunsher
Copy link
Contributor

Crunsher commented Apr 6, 2017

I completly overlooked this issues content and did not notice @TheFlyingCorpse already had a PR for it.
Sorry ;_;

My solution only differs by checking the openssl minor version instead of the file paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Windows agent and plugins enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants