Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #13309] Service_set has no host relation in db #624

Closed
icinga-migration opened this issue Nov 24, 2016 · 9 comments
Closed
Labels
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13309

Created by mfrosch on 2016-11-24 11:19:30 +00:00

Assignee: mfrosch
Status: Resolved (closed on 2016-12-13 13:51:23 +00:00)
Target Version: 1.3.0
Last Update: 2016-12-13 13:51:23 +00:00 (in Redmine)


Or deletetion handling.

Deleting a host with service sets can break things.

Changesets

2016-11-25 08:06:01 +00:00 by mfrosch a2df4c8

IcingaServiceSet: Check if object_name is unique for templates

refs #13309

2016-11-25 08:06:14 +00:00 by mfrosch d408f72

IcingaServiceSetTest: Add test case

refs #13309

2016-11-25 08:06:16 +00:00 by mfrosch 6af75c0

WIP: Add schema migration for ServiceSet foreign keys

refs #13309

2016-11-28 14:32:41 +00:00 by mfrosch 3a8cad2

IcingaServiceSet: Check if object_name is unique for templates

refs #13309

2016-11-28 14:32:41 +00:00 by mfrosch 84f39a6

IcingaServiceSetTest: Add test case

refs #13309

2016-11-28 15:46:47 +00:00 by mfrosch 64284ee

Add schema migration for ServiceSet foreign keys

This will clean up dangling service_set for non-existing host and service for service_set

refs #13309

Relations:

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-28 08:03:20 +00:00

  • Duplicated set to 13337

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-28 08:07:41 +00:00

  • Priority changed from Normal to High

We must apply the queries from the linked issue before the migration, then we should be fine. Queries need to be restructured for PostgreSQL as it can't DELETE in a JOIN - at least as far as I remember.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-05 16:06:12 +00:00

  • Relates set to 13401

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-07 09:30:13 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfrosch
  • Priority changed from High to Normal
  • Target Version set to 1.3.0

Had to push a small modification, but to me this is fine right now.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-07 09:30:23 +00:00

  • Status changed from Assigned to Resolved

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-08 10:04:14 +00:00

  • Status changed from Resolved to Assigned
  • Done % changed from 0 to 90

Have to reopen this, IMO the constraint is wrong - DELETEing a host should CASCADE to it's sets. Currently you cannot delete a Host unless it has a service set.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-13 08:53:14 +00:00

  • Relates set to 13531

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-13 13:51:23 +00:00

  • Status changed from Assigned to Resolved

As we have a dedicated bug report right now I'll close this one.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-12-14 21:30:36 +00:00

  • Relates set to 13591

@icinga-migration icinga-migration added this to the 1.3.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant