New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #13195] Semicolons in plugin output are converted to colon #4785
Comments
Updated by gbeutner on 2016-11-15 10:10:57 +00:00 CompatUtility::GetCheckResultOutput seems to be the culprit here. According to Michael this was added to improve compatibility with how Icinga 1.x handles this. The rationale being that shell scripts would have to replace semi-colons with colon when using macro values in external commands. We should probably discuss whether to change this behavior.
|
Guess we can only change that for DB IDO, all other interfaces might break (esp. Livestatus and statusdata)
|
Consider it for a new backend, and partially adopt features like GelfWriter. |
The only real problem lies with using the output and passing it into the command pipe again. Tools should already have a safety mechanism for user inputs with colons either. I'll fix that for 2.9. |
This affects all interfaces which are using the CompatUtility class format helpers for short and long output. fixes #4785
This issue has been migrated from Redmine: https://dev.icinga.com/issues/13195
Created by elippmann on 2016-11-15 09:30:47 +00:00
Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-11-15 10:10:57 +00:00 (in Redmine)
For example one can't use HTML entities in the plugin output.
The text was updated successfully, but these errors were encountered: