Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12925] Open firewall during Icinga 2 Windows agent #4733

Closed
icinga-migration opened this issue Oct 14, 2016 · 6 comments
Closed
Labels
area/setup Installation, systemd, sample files area/windows Windows agent and plugins enhancement New feature or request queue/wishlist

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12925

Created by twidhalm on 2016-10-14 11:40:40 +00:00

Assignee: elippmann
Status: New
Target Version: (none)
Last Update: 2016-10-17 13:01:25 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

Hi,

I just learned from a Windows admin at a customers that it's best practice that Windows install routines should open firewall ports and bind them to the corresponding .exe file no matter if the firewall is running on the host or not.

It might be a good idea to make the Windows install routine accord to the Microsoft best practices.

Cheers,
Thomas

@icinga-migration
Copy link
Author

Updated by twidhalm on 2016-10-14 12:03:24 +00:00

I'm sorry I have to rephrase request to make it a bit more precise. We did not find a official best practice guide from Microsoft that says that an installer should open the firewall ports. But we can not verify what Microsoft want installers to do.

What we have:

  • A document (for game developers) that shows how an installer can open a firewall port
  • An experienced Windows admin who tells me that it is common practice for installers from big vendors (and Microsoft themself) to open ports automatically.

As a *nix admin I wouldn't want any installer messing with my firewall but maybe life's different in a Windows world.

Maybe we should check if someone in the team has connections to Microsoft developers that could verify whether this is a best or just a common practice.

@icinga-migration
Copy link
Author

Updated by twidhalm on 2016-10-14 12:24:37 +00:00

I just talked to @cstein and he said that many Windows installers offer an option to set a firewall exception.

So maybe it would be nice to have a checkbox / cli flag to add a firewall exception. Either during installation ( icinga2.msi /q /firewall ) or during the first-run-wizard. The later would offer the possibility to open the firewall not to the world but only to the masters / slaves the agent should connect to.

@icinga-migration
Copy link
Author

Updated by twidhalm on 2016-10-17 13:01:25 +00:00

  • Assigned to set to elippmann

I talked to @cstein again about making this configurable.

While we don't know what Microsoft best practices say we both think an optional firewall configuration might be the best way to go. Some things to consider:

  • using a checkbox during graphical installation and a commandline option during silent installation to open the default port for the icinga2.exe file to the world might be enough for most users
  • setting the firewall during the first run wizard or @cstein s kickstart script would allow to open the firewall connection just for the icinga 2 masters or slaves and maybe use a custom port might be better. I don't know if Windows permissions allow doing so.
  • If we restrict the connection from/to the masters then we should use a prominent info for the user because new masters will not be allowed to connect to the agent.

@ELippmann , could you consider including this feature into to msi installer or the first run wizard?

@dnsmichi
Copy link
Contributor

Ask @lippserd directly for a raised priority on this.

@dnsmichi dnsmichi added area/setup Installation, systemd, sample files queue/wishlist and removed setup/cmake labels May 9, 2019
@dnsmichi dnsmichi added this to the 2.12.0 milestone Sep 2, 2019
@dnsmichi dnsmichi self-assigned this Sep 2, 2019
@dnsmichi
Copy link
Contributor

dnsmichi commented Sep 4, 2019

wixtoolset/issues#5869

@dnsmichi dnsmichi modified the milestones: 2.12.0, 2.13.0 Oct 8, 2019
@dnsmichi dnsmichi removed their assignment Nov 15, 2019
@dnsmichi
Copy link
Contributor

With the new Icinga for windows package developed by @LordHepipud this won't be taken into account for future development iterations. Learn more about this new project here: https://icinga.com/2019/11/05/icinga-for-windows-rc-available/

@dnsmichi dnsmichi removed this from the 2.13.0 milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setup Installation, systemd, sample files area/windows Windows agent and plugins enhancement New feature or request queue/wishlist
Projects
None yet
Development

No branches or pull requests

4 participants