Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #1289] segfaults if no default_user_name= given in cgi.cfg #579

Closed
icinga-migration opened this issue Mar 15, 2011 · 4 comments
Closed

[dev.icinga.com #1289] segfaults if no default_user_name= given in cgi.cfg #579

icinga-migration opened this issue Mar 15, 2011 · 4 comments
Labels
bug Classic UI
Milestone
1.4

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1289

Created by hephaestus on 2011-03-15 23:03:20 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2011-03-16 20:48:51 +00:00)
Target Version: 1.4
Last Update: 2014-12-08 09:42:11 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

RHEL 5.4 x86_64
Icinga 1.3.0

Without specifying a default_user_name, running 'REQUEST_METHOD=GET gdb ./status.cgi', the cgi segfaults:

(gdb) bt

#0  0x0000003932c796f0 in strlen () from /lib64/libc.so.6
#1  0x0000000000415bad in get_authentication_information (authinfo=0x64d760) at cgiauth.c:105
#2  0x000000000040e297 in main () at status.c:265

(gdb)

Changesets

2011-03-16 16:44:14 +00:00 by mfriedrich 5afdc14

classic ui: fix segfaults if no default_user_name= given in cgi.cfg #1289

fixes #1289

2011-03-30 11:24:55 +00:00 by mfriedrich 316e914

classic ui: fix segfaults if no default_user_name= given in cgi.cfg #1289

fixes #1289
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-03-15 23:20:52 +00:00

  • Target Version changed from 1.3 to 1.4

the strtok above returns a null ptr which is not good for strlen (should bail out with an error before). this comes in from the cgiauth patch which is a bit buggy.

https://git.icinga.org/?p=icinga-core.git;a=blob;f=cgi/cgiauth.c;h=4884d3880a4ad8dc8c1121d1c4d5d795bf308267;hb=HEAD#l102

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-03-16 16:43:28 +00:00

  • Subject changed from Segfaults if no auth user specified to segfaults if no default_user_name= given in cgi.cfg
  • Category set to 43
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2011-03-16 20:48:51 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 5afdc14.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-08 09:42:11 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 43 to Classic UI
  • Icinga Version set to 1
  • OS Version set to any

@icinga-migration icinga-migration added this to the 1.4 milestone Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Classic UI
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
1 participant
@icinga-migration