[dev.icinga.com #12879] OpenTsdbWriter dot not insert metric names with colon character :

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12879

Created by jre3brg on 2016-10-10 06:44:04 +00:00

Assignee: tobiasvdk
Status: Assigned
Target Version: (none)
Last Update: 2016-11-11 10:02:08 +00:00 (in Redmine)

Icinga Version: v2.5.4
Backport?: Not yet backported
Include in Changelog: 1

---

OpenTsdbWriter do not insert metric names with colon character. Metrics came from Windows agents include colon on disk drive letters !

[2016-10-10 08:34:42 +0200] debug/OpenTsdbWriter: Add to metric list:'put icinga.service.disk.C:_ 1476081281 15031336960 host=xyz_xyz_xyz'.

Changesets

2016-10-20 20:50:33 +00:00 by (unknown) ba81472

Fix metric and tag escaping for OpenTSDB writer

Currently only the following characters are allowed: a to z, A to Z,
0 to 9, -, _, ., / so use a regex to replace other characters with an
_ (underscore).

refs #12879

[icinga-migration]

Updated by gbeutner on 2016-10-11 10:39:57 +00:00

• Status changed from New to Assigned
• Assigned to set to tobiasvdk

tobiasvdk: Can you have a look at this please?

[icinga-migration]

Updated by tobiasvdk on 2016-10-11 10:59:35 +00:00

Colons are not supported in metric or tag names, see http://opentsdb.net/docs/build/html/user\_guide/writing.html#metrics-and-tags so they must be replaced. I will check the code tomorrow.

[icinga-migration]

Updated by gbeutner on 2016-11-02 12:45:27 +00:00

Any update on this? :)

[icinga-migration]

Updated by tobiasvdk on 2016-11-11 10:02:08 +00:00

gunnarbeutner wrote:

Any update on this? :)
We are currently working it.

[jre3brg]

I would propose to replace all characters not allowed by opentsdb by underscore to avoid further incompatibilities with metric name. As example a windows path needs the colon character for windows disk size check.

[dnsmichi]

Send a PR please, this will be assigned a target issue then. This one has no progress at all.