Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev.icinga.com #12874] check_nscp #4721

Closed
icinga-migration opened this issue Oct 7, 2016 · 4 comments
Closed

[dev.icinga.com #12874] check_nscp #4721

icinga-migration opened this issue Oct 7, 2016 · 4 comments
Labels
area/windows Windows agent and plugins enhancement New feature or request

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12874

Created by jflach on 2016-10-07 13:25:37 +00:00

Assignee: jflach
Status: Assigned
Target Version: (none)
Last Update: 2016-10-10 14:20:03 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

Changesets

2016-10-07 13:29:45 +00:00 by jflach a8c13c3

Start working on check_nscp

refs #12874

2016-10-07 13:49:56 +00:00 by jflach fc1b645

Improve HTTP Handler error message

refs #12874

2016-10-07 14:06:20 +00:00 by jflach a2fcd55

Check_nscp v0.1

refs #12874

2016-10-07 14:25:06 +00:00 by jflach 486ad6c

Add CheckCommand for check_nscp.exe

Currently Windows only

refs #12874

2016-10-10 15:35:09 +00:00 by jflach d18770a

Fix itl entry for check_nscp

refs #12874

2016-10-11 13:35:22 +00:00 by jflach da3fb2e

Format changes to check_nscp

refs #12874

2016-10-11 13:36:39 +00:00 by jflach cf17ea9

Add additional error checking to check_nscp

refs #12874

2016-10-11 14:52:30 +00:00 by jflach 7b2663b

Add informational error output

refs #12874

2016-10-13 16:18:08 +00:00 by jflach 8c08956

Update ITL for check_nscp

refs #12874

2016-10-13 16:19:15 +00:00 by jflach 39752b7

Build check_nscp on Linux too

refs #12874

2016-10-14 11:15:28 +00:00 by jflach 8eb1983

Fix Cmake for check_nscp

refs #12874

2016-10-14 13:53:29 +00:00 by jflach a654be0

Add comments and debug mode to check_nscp

refs #12874

2016-10-14 13:53:29 +00:00 by jflach 380db55

Fix CMake

refs #12874

2016-10-14 13:54:34 +00:00 by jflach 81e7189

Fix compiler error

VS allows void main

refs #12874

2016-10-27 11:53:27 +00:00 by jflach f89e4a2

Remove check_nscp from command-plugins

Otherwise it breaks the windows default conf and since we probably won't
have check_nscp on Linux it's better to remove it for now

refs #12874

2016-12-08 11:24:40 +00:00 by jflach 21737a7

Fix Url parser when using path only

refs #12874

2016-12-08 12:48:15 +00:00 by jflach 115d4b5

Add docs for check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 5340582

Start working on check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 6db3c9b

Improve HTTP Handler error message

refs #12874

2016-12-08 13:02:41 +00:00 by jflach acbe618

Check_nscp v0.1

refs #12874

2016-12-08 13:02:41 +00:00 by jflach bc1bc63

Add CheckCommand for check_nscp.exe

Currently Windows only

refs #12874

2016-12-08 13:02:41 +00:00 by jflach b91314b

Fix itl entry for check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 9fd9daa

Format changes to check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach e1c883f

Add additional error checking to check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach e2c26d1

Add informational error output

refs #12874

2016-12-08 13:02:41 +00:00 by jflach a15d262

Update ITL for check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 1d18b2c

Build check_nscp on Linux too

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 08dd722

Fix Cmake for check_nscp

refs #12874

2016-12-08 13:02:41 +00:00 by jflach 116ffdb

Add comments and debug mode to check_nscp

Also update cmake

refs #12874

2016-12-08 13:03:06 +00:00 by jflach 354e75f

Remove check_nscp from command-plugins

Otherwise it breaks the windows default conf and since we probably won't
have check_nscp on Linux it's better to remove it for now

refs #12874

2016-12-08 13:03:06 +00:00 by jflach ce0acb2

Add docs for check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach acb9fa9

Start working on check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 379662b

Improve HTTP Handler error message

refs #12874

2016-12-08 13:30:12 +00:00 by jflach e8e6c6a

Check_nscp v0.1

refs #12874

2016-12-08 13:30:12 +00:00 by jflach d05f832

Add CheckCommand for check_nscp.exe

Currently Windows only

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 97bdfd7

Fix itl entry for check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach d049da5

Format changes to check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 6ae743f

Add additional error checking to check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 3b596d3

Add informational error output

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 431133a

Update ITL for check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach aebc28a

Build check_nscp on Linux too

refs #12874

2016-12-08 13:30:12 +00:00 by jflach c2235fa

Fix Cmake for check_nscp

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 3316684

Add comments and debug mode to check_nscp

Also update cmake

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 276d51a

Remove check_nscp from command-plugins

Otherwise it breaks the windows default conf and since we probably won't
have check_nscp on Linux it's better to remove it for now

refs #12874

2016-12-08 13:30:12 +00:00 by jflach 02d81cc

Add docs for check_nscp

refs #12874

2016-12-08 14:35:21 +00:00 by jflach d265c85

Add image for check_nscp doc

refs #12874

Subtasks:
@icinga-migration icinga-migration added enhancement New feature or request Plugins labels Jan 17, 2017
@dnsmichi dnsmichi added the area/windows Windows agent and plugins label Mar 20, 2017
@dnsmichi dnsmichi self-assigned this Mar 20, 2017
@dnsmichi dnsmichi added this to the 2.7.0 milestone Mar 20, 2017
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Start working on check_nscp
8dd62ae 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Improve HTTP Handler error message
0399987 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Check_nscp v0.1
901416f 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Add CheckCommand for check_nscp.exe
6a97210 
Currently Windows only

refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Fix itl entry for check_nscp
2bde375 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Format changes to check_nscp
2008760 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Add additional error checking to check_nscp
81fad7c 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Add informational error output
05aa803 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Update ITL for check_nscp
9062729 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Build check_nscp on Linux too
3c7052a 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Fix Cmake for check_nscp
948c9f0 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Add comments and debug mode to check_nscp
f810214 
Also update cmake

refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Fix url parser
be79c7a 
refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Remove check_nscp from command-plugins
2ee6604 
Otherwise it breaks the windows default conf and since we probably won't
have check_nscp on Linux it's better to remove it for now

refs #4721
dnsmichi pushed a commit that referenced this issue Mar 20, 2017
@Crunsher
Add docs for check_nscp
07b3c8c 
refs #4721
@dnsmichi
Copy link
Contributor

dnsmichi commented Mar 20, 2017 •
edited

Contains a reference to #4725 - which is merged to master partially. Any ideas @Crunsher ?

I've rebased the branch against current master, as well as edited the commit id references. It's now a new branch called feature/check_nscp-4721.

Before we start a review to merge we should discuss the following

  • rename check_nscp to check_nscp_api or check_nscp_http to better reflect its purpose. This also avoids name collisions with nsclient itself, and our ITL CheckCommand nscp which actually is using check_nt.
  • Decide whether to build and ship it on Linux too (would be a nice addition, but not a requirement for now).

The patches contain a couple of whitespace fixes too but weren't causing trouble during rebase.

@Crunsher
Copy link
Contributor

rename check_nscp to check_nscp_api or check_nscp_http to better reflect its purpose. This also avoids name collisions with nsclient itself, and our ITL CheckCommand nscp which actually is using check_nt.

Renaming the plugin is a sound idea. I like 'check_nscp_api' for the binary and 'nscp-api' for the ITL.

Decide whether to build and ship it on Linux too (would be a nice addition, but not a requirement for now).

At the time I decided against building it for Linux because we didn't ship any plugins with the Linux version of Icinga 2. I thought about shipping it separately (Icinga Exchange) but as it uses Icinga 2 libraries dropped the idea :D This is a decision we should also involve @gunnarbeutner in, as it would set precedence.

The patches contain a couple of whitespace fixes too but weren't causing trouble during rebase.

Damn, I need to be more careful about what I commit

@gunnarbeutner
Copy link
Contributor

After a very brief discussion @dnsmichi and I have decided not to provide the plugin in the *nix version. :)

dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Start working on check_nscp
ec36959 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Improve HTTP Handler error message
cf7abd2 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Check_nscp v0.1
028ee05 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Add CheckCommand for check_nscp.exe
b2c3f63 
Currently Windows only

refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Fix itl entry for check_nscp
766d189 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Format changes to check_nscp
ca335eb 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Add additional error checking to check_nscp
a280f8f 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Add informational error output
4a4d35f 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Update ITL for check_nscp
4ee6c75 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Build check_nscp on Linux too
cb44cc9 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Fix Cmake for check_nscp
3c34da8 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Add comments and debug mode to check_nscp
acccd3c 
Also update cmake

refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Fix url parser
4bf65eb 
refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Remove check_nscp from command-plugins
35c0593 
Otherwise it breaks the windows default conf and since we probably won't
have check_nscp on Linux it's better to remove it for now

refs #4721
dnsmichi pushed a commit that referenced this issue May 10, 2017
@Crunsher
Add docs for check_nscp
a1d76c7 
refs #4721
@dnsmichi dnsmichi mentioned this issue May 10, 2017
Merged
5 tasks
dnsmichi pushed a commit that referenced this issue Jun 12, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
eed1a4c 
refs #4721
dnsmichi pushed a commit that referenced this issue Jun 13, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
1e6597f 
refs #4721
dnsmichi pushed a commit that referenced this issue Jun 13, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
b6b6c88 
refs #4721
dnsmichi pushed a commit that referenced this issue Jun 13, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
145d96f 
refs #4721
@dnsmichi
Copy link
Contributor

Continuing in #5239 in favor of this old working ticket.

@dnsmichi dnsmichi removed this from the 2.7.0 milestone Jun 13, 2017
dnsmichi pushed a commit that referenced this issue Jun 13, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
39c24e9 
refs #4721
lazyfrosch added a commit that referenced this issue Jun 14, 2017
@lazyfrosch
icinga2.spec: Define ICINGA2_PLUGINDIR only once
a0d3357 
refs #4721
Crunsher added a commit that referenced this issue Jul 28, 2017
@Crunsher
Add check_nscp_api plugin for NSClient++ API checks
6d7e202 
refs #4721
Crunsher pushed a commit that referenced this issue Jul 28, 2017
@lazyfrosch @Crunsher
icinga2.spec: Define ICINGA2_PLUGINDIR only once
4c3dc19 
refs #4721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/windows Windows agent and plugins enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dnsmichi @gunnarbeutner @Crunsher @icinga-migration