[dev.icinga.com #12621] Invalid API filter error messages

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12621

Created by JamesForman on 2016-09-02 04:02:56 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2016-09-02 06:55:05 +00:00)
Target Version: 2.6.0
Last Update: 2016-09-02 06:55:05 +00:00 (in Redmine)

Icinga Version: 2.5.3
Backport?: Not yet backported
Include in Changelog: 1

---

We have been experimenting with the API and have found that if an invalid filter is specified there can be a large amount of unhelpful log spam.

The filter that was specified in this case was: "event.check_result.exit_status=CheckResult", where "type" is invalid.

The error message output was multiple copies of the below message (I've attached a few seconds of the log).

[2016-08-31 13:39:35 +1200] warning/JsonRpcConnection: Error while processing message for identity 'serverX'
Error: Error while evaluating expression: Tried to access undefined script variable 'type'
Location: in : 1:35-1:38

It would be ideal if the error could:

• State the name of the user causing the error
• Not have a blank line

icinga2 - The Icinga 2 network monitoring daemon (version: r2.5.3-1)

System information:
  Platform: Ubuntu
  Platform version: 16.04.1 LTS (Xenial Xerus)
  Kernel: Linux
  Kernel version: 4.4.0-31-generic
  Architecture: x86_64

Attachments

• Icinga2_Bug_APIErrors.txt JamesForman - 2016-09-02 03:53:47 +00:00 - A few seconds of errors

Changesets

2016-09-02 06:51:51 +00:00 by gbeutner 58cdce8

Improve error handling for event filters

fixes #12621

[icinga-migration]

Updated by gbeutner on 2016-09-02 06:04:55 +00:00

• Status changed from New to Assigned
• Assigned to set to gbeutner
• Target Version set to 2.6.0

[icinga-migration]

Updated by gbeutner on 2016-09-02 06:55:05 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 58cdce8.