[dev.icinga.com #12616] Add modifier capitalize to import

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12616

Created by dgoetz on 2016-09-01 11:41:26 +00:00

Assignee: dgoetz
Status: Feedback
Target Version: (none)
Last Update: 2016-12-13 11:31:50 +00:00 (in Redmine)

---

Find a git patch attached which adds modifier capitalize which can simply capitalize a field during import.

Attachments

• 0001-adds-modifier-capitalize.patch dgoetz - 2016-09-01 11:39:27 +00:00

[icinga-migration]

Updated by tgelf on 2016-09-05 08:14:31 +00:00

-> add "lowercase first" option

[icinga-migration]

Updated by tgelf on 2016-12-13 10:17:53 +00:00

• Status changed from New to Feedback
• Assigned to set to dgoetz

As we recently talked about this, it is still missing the mentioned config flag as not everybody might want to lowercase first. Should this be two modifiers (lowercase is already there), or should we add a config flag for this modifier allowing one to adjust the behavior of the "capitalize" modifier? And in case you opt for the latter, would you want to try to add such a form element to your patch as an exercise - or would you prefer me doing so?

Cheers,
Thomas

[icinga-migration]

Updated by dgoetz on 2016-12-13 11:31:50 +00:00

I think chaining these modifiers will work, but having only one is more user friendly.
If you could add this, I would be happy. If you are also busy, I will give it a try when I find some time.

[dgoetz]

I created a pull request for this, it uses a selectbox for decision if lowercase should be used with default true as I found no example for a checkbox.