[dev.icinga.com #12574] missleading help text when adding a blacklist

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12574

Created by evgeni on 2016-08-28 08:12:43 +00:00

Assignee: (none)
Status: Closed (closed on 2016-12-07 18:30:28 +00:00)
Target Version: (none)
Last Update: 2016-12-07 18:30:28 +00:00 (in Redmine)

Icinga Version: 2.5.3
Backport?: Not yet backported
Include in Changelog: 1

---

ohai,

# icinga2 node blacklist add --help
...
Command options:
  --zone arg            The name of the zone
  --host arg            The name of the host
  --service arg         The name of the service

Given those are options, I expected them to be optional, but they aren't:

root@genshi:~# icinga2 node blacklist add --host '*' --service ping6
critical/cli: At least the zone name filter is required!
root@genshi:~# icinga2 node blacklist add --zone '*' --service ping6
critical/cli: At least the host name filter is required!
root@genshi:~# icinga2 node blacklist add --zone '*' --host '*' --service ping6
(this was OK)

While I think that when all three parameters are mandatory, they should be positional arguments, not options, but that's not for me to decide here :)

• The --help text could be improved, saying that actually all of them are mandatory (or make them default to '*'?)
• The error message should not say "at least" as this implies that the other options are not mandatory

Thanks!

[icinga-migration]

Updated by evgeni on 2016-08-28 08:12:58 +00:00

I did not test, but I guess the same applies to the whitelist too.

[icinga-migration]

Updated by mfriedrich on 2016-08-29 09:28:36 +00:00

• Category set to CLI
• Status changed from New to Feedback
• Assigned to set to evgeni

Hi,

do you have a patch please? :)

[icinga-migration]

Updated by mfriedrich on 2016-12-07 18:30:28 +00:00

• Status changed from Feedback to Closed
• Assigned to deleted evgeni

Those commands are deprecated in v2.6 so this is a wont fix, thanks anyways.