Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #12559] HTML Anchor "#" url escaping in HOSTNOTESURL and SERVICENOTESURL #1584

Closed
icinga-migration opened this issue Aug 26, 2016 · 0 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12559

Created by flohoff on 2016-08-26 09:57:39 +00:00

Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-08-26 09:57:39 +00:00 (in Redmine)

Icinga Version: 1.11.6
OS Version: Debian/GNU/Linux 8.5

Hi,
the icinga1 core escapes HOSTNOTESURL and SERVICENOTESURL non url character for example the mail notification.

The problem is that it also escapes the "#" HTML anchor characters which makes it impossible to use. (%23 is NOT the same as the "#" in the URL)

The right and radical solution would be to do NO escaping at all as then the admin can choose whatever he likes. This would break backward compatibility so just adding the "#" to the non-escape characters would be the right thing to do.

Flo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants