[dev.icinga.com #12274] -q option for check_ntp_time is wrong

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12274

Created by bardahlm on 2016-08-01 13:47:57 +00:00

Assignee: bardahlm
Status: Resolved (closed on 2016-08-09 08:45:06 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-09 08:45:06 +00:00 (in Redmine)

Icinga Version: 2.4.10
Backport?: Not yet backported
Include in Changelog: 1

---

In file itl/command-plugins.conf, around line 873 the following should be changed:

• "-q" = "$ntp_quit$"

• "-q" = {
• set_if = "$ntp_quiet$"
• description = "Returns UNKNOWN instead of CRITICAL if offset cannot be found"
• }

ref: https://www.monitoring-plugins.org/doc/man/check\_ntp\_time.html

Attachments

• 12274 ntp_time q option.patch bardahlm - 2016-08-03 09:00:54 +00:00

Changesets

2016-08-09 08:43:55 +00:00 by bardahlm 39890c0

Fix incorrect custom variable name for the -q option for ntp_time.

fixes #12274

Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>

2016-08-09 08:43:55 +00:00 by gbeutner 1aac54f

Update AUTHORS

refs #12274

[icinga-migration]

Updated by gbeutner on 2016-08-01 13:50:31 +00:00

• Category set to ITL
• Status changed from New to Assigned
• Assigned to set to bardahlm

Can you please provide a patch in the format that's used by "git format-patch"? Also, please update the documentation for the -q option and make sure that the 'Author' attribute in your .patch file contains your real name.

[icinga-migration]

Updated by bardahlm on 2016-08-02 05:53:59 +00:00

As far as I know this is documented here: http://docs.icinga.org/icinga2/latest/doc/module/icinga2/chapter/plugin-check-commands#plugin-check-command-ntp-time. How do I update that file?

[icinga-migration]

Updated by gbeutner on 2016-08-03 08:24:56 +00:00

You can find the documentation in the 'doc' directory:

$ grep -r ntp_time doc/
doc//10-monitoring-remote-systems.md:* [ntp_time](7-icinga-template-library.md#plugin-check-command-ntp-time)
doc//7-icinga-template-library.md:###  ntp_time
doc//7-icinga-template-library.md:Check command object for the `check_ntp_time` plugin.
doc//7-icinga-template-library.md:ntp_timeoffset  | **Optional.** Expected offset of the ntp server relative to local server (seconds).
doc//7-icinga-template-library.md:ntp_timeout     | **Optional.** Seconds before connection times out (default: 10).
doc//7-icinga-template-library.md:ntp_timeout     | **Optional.** Seconds before connection times out (default: 10).

[icinga-migration]

Updated by bardahlm on 2016-08-03 09:03:16 +00:00

• File added 12274 ntp_time q option.patch

Hopefully this patch is correct.
I do not have a development installation where I can run git commands so the patch is generated from github from this URL: https://github.com/Icinga/icinga2/compare/master...bardahlm:master.patch?diff=unified&name=master

[icinga-migration]

Updated by gbeutner on 2016-08-09 08:44:20 +00:00

• Target Version set to 2.5.0

[icinga-migration]

Updated by bardahlm on 2016-08-09 08:45:06 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 39890c0.