[dev.icinga.com #12040] Add CheckCommand definition for check_glusterfs

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12040

Created by hostedpower on 2016-06-25 13:03:05 +00:00

Assignee: hostedpower
Status: Resolved (closed on 2016-08-29 10:11:40 +00:00)
Target Version: 2.6.0
Last Update: 2016-12-13 07:32:06 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

---

Hi,

No checks are provided for these storage systems. I will create a patch for glusterfs. I think ceph should be supported too :)

Attachments

• 0001-Add-support-for-glusterfs-checks.patch hostedpower - 2016-06-25 13:06:47 +00:00
• 0001-Add-support-for-glusterfs-checks.patch hostedpower - 2016-07-04 06:27:04 +00:00

Changesets

2016-08-29 10:04:47 +00:00 by hostedpower 0a76921

Add support for glusterfs checks

fixes #12040

Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>

2016-08-31 13:24:04 +00:00 by mfriedrich 996a7eb

ITL: Fix typo in glusterfs CheckCommand definition

refs #12040

[icinga-migration]

Updated by hostedpower on 2016-06-25 13:06:52 +00:00

• File added 0001-Add-support-for-glusterfs-checks.patch

Patch for gluster

[icinga-migration]

Updated by gbeutner on 2016-07-04 05:48:22 +00:00

• Status changed from New to Assigned
• Assigned to set to hostedpower

Please update the patch to include your real name in the Author field.

[icinga-migration]

Updated by hostedpower on 2016-07-04 06:27:44 +00:00

• File added 0001-Add-support-for-glusterfs-checks.patch

Hi,

Here is the updated patch. Sorry for not providing any other email address, but you can thank the spammers for that!

Best regards
Jo

[icinga-migration]

Updated by hostedpower on 2016-08-28 18:46:02 +00:00

Hi,

Any update on this? To be honest it's quite frustrating when trying to give back to the community and discovering stuff is rejected or not taken into account because a name is not "correct" according to your terms :(

[icinga-migration]

Updated by gbeutner on 2016-08-29 10:06:19 +00:00

• Target Version set to 2.6.0

Well, we're only human - looks like we missed this patch for 2.5, sorry. I took the liberty of cleaning up your patch and merging it into the master branch.

There still were a few issues with your patch which you might consider for the future:

• Missing header for the storage.conf file.
• Spelling mistake: glusterfs_inodcrit
• I renamed some of the custom variables to make them more readable.
• Turned the custom vars into numbers (i.e., removed the quotes around the values)

[icinga-migration]

Updated by hostedpower on 2016-08-29 10:11:40 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 0a76921.

[icinga-migration]

Updated by hostedpower on 2016-08-29 10:14:42 +00:00

Thanks for the fixes and the tips for next time!!

I see one more typo remained: vars.glusterfs_inod_critical = 95
Should be: vars.glusterfs_inode_critical = 95

[icinga-migration]

Updated by mfriedrich on 2016-08-31 13:25:04 +00:00

Fixed thx.

[icinga-migration]

Updated by mfriedrich on 2016-11-18 14:22:10 +00:00

• Subject changed from No support for storage technologies like gluster, ceph , ... to Add glusterfs CheckCommand

[icinga-migration]

Updated by gbeutner on 2016-12-13 07:32:06 +00:00

• Subject changed from Add glusterfs CheckCommand to Add CheckCommand definition for check_glusterfs