[dev.icinga.com #11890] Config validation should not delete comments/downtimes w/o reference

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11890

Created by mfriedrich on 2016-06-03 08:57:06 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-06-06 11:08:40 +00:00)
Target Version: 2.5.0
Last Update: 2016-06-06 11:08:40 +00:00 (in Redmine)

Icinga Version: 2.4.10
Backport?: Not yet backported
Include in Changelog: 1

---

• include_recursive in CompileFile() should ignore files not being available
• Comments/Downtimes cleanup should happen after all objects have been activated

critical/config: Error: Error while evaluating expression: Function call 'std::ifstream::open' for file '/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/conf.d/comments/testhost.domain.com!load!icingamaster01-1464565201-11114.conf' failed with error code 2, 'No such file or directory'

Location: in /var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf: 3:3-3:28

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(1): include "../active.conf"

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(2): if (ActiveStages["_api"] == "icingamaster01-1460550672-12886") {

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(3):   include_recursive "conf.d"

                                                                                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(4):   include_zones "_api", "zones.d"

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(5): }

critical/config: Error: Error while evaluating expression: Function call 'std::ifstream::open' for file '/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/conf.d/comments/testhost.domain.com!ping4!mon-icingamaster-02.domain.com-1464584702-5011.conf' failed with error code 2, 'No such file or directory'

Location: in /var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf: 3:3-3:28

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(1): include "../active.conf"

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(2): if (ActiveStages["_api"] == "icingamaster01-1460550672-12886") {

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(3):   include_recursive "conf.d"

                                                                                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(4):   include_zones "_api", "zones.d"

/var/lib/icinga2/api/packages/_api/icingamaster01-1460550672-12886/include.conf(5): }


information/ConfigCompiler: Compiling config file: /var/lib/icinga2/api/packages/director/include.conf

Changesets

2016-06-03 12:16:52 +00:00 by mfriedrich 21bea17

Ensure that obsolete comment/downtime objects are deleted after activating objects

Config validation shouldn't be able to purge the files, only on
restart.

refs #11890

2016-06-03 12:42:32 +00:00 by mfriedrich d4d679e

Ensure that obsolete comment/downtime objects are deleted after activating objects

Config validation shouldn't be able to purge the files, only on
restart.

refs #11890

2016-06-06 11:07:49 +00:00 by mfriedrich 8b742e8

Ensure that obsolete comment/downtime objects are deleted after activating objects

Config validation shouldn't be able to purge the files, only on
restart.

fixes #11890

[icinga-migration]

Updated by gbeutner on 2016-06-06 11:08:37 +00:00

• Status changed from New to Assigned
• Assigned to set to mfriedrich

[icinga-migration]

Updated by mfriedrich on 2016-06-06 11:08:40 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 8b742e8.