[dev.icinga.com #10881] Move iframe from modules to framework

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10881

Created by tgelf on 2015-12-17 16:45:27 +00:00

Assignee: aklimov
Status: Resolved (closed on 2016-02-09 13:00:05 +00:00)
Target Version: 2.2.0
Last Update: 2016-02-14 15:11:13 +00:00 (in Redmine)

---

The iframe module basically consists of two lines of code, plus brackets and a namespace/class/function-definition. Is there anything that hinders us from making this part of our default functionality? Currently most users are confused, as they have no Idea what this module is all about. Iframes, ok. And then?

Cheers,
Thomas

Changesets

2016-02-09 12:37:53 +00:00 by aklimov 7fe71f7

Integrate the iframe module into the framework

refs #10881

2016-02-09 12:39:44 +00:00 by aklimov 86834c4

Add missing html structure to view script

refs #10881

2016-02-09 12:54:56 +00:00 by aklimov 8958873

Change the height of iframes to 99%

refs #10881

2016-02-09 12:58:07 +00:00 by aklimov 1abd1d2

Merge branch 'bugfix/move-iframe-from-modules-to-framework-10881'

fixes #10881

---

Relations:

• duplicates #10881

[icinga-migration]

Updated by tgelf on 2015-12-17 16:46:24 +00:00

• Relates set to 10400

[icinga-migration]

Updated by elippmann on 2016-01-05 10:26:37 +00:00

• Subject changed from Please consider making the iframe module no longer a module to Move iframe from modules to framework
• Category set to Framework
• Target Version set to 2.2.0

[icinga-migration]

Updated by elippmann on 2016-01-05 10:26:50 +00:00

• Relates deleted 10400

[icinga-migration]

Updated by elippmann on 2016-01-05 10:27:39 +00:00

• Duplicated set to 10400

[icinga-migration]

Updated by jmeyer on 2016-02-09 12:06:28 +00:00

• Status changed from New to Assigned
• Assigned to set to aklimov

While you're working on this, please also fix the index action's view script which is missing the usual html structure. (tabs and content)

[icinga-migration]

Updated by aklimov on 2016-02-09 12:42:16 +00:00

• Status changed from Assigned to Feedback
• Assigned to changed from aklimov to jmeyer

[icinga-migration]

Updated by jmeyer on 2016-02-09 12:55:23 +00:00

• Status changed from Feedback to Assigned
• Assigned to changed from jmeyer to aklimov

[icinga-migration]

Updated by aklimov on 2016-02-09 13:00:05 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 1abd1d2.

[icinga-migration]

Updated by mfriedrich on 2016-02-14 15:11:13 +00:00

This change broke the rpm builds on build.icinga.org as the spec file tries to copy the iframe module. Please verify that next time.

I've fixed that with 1fcbe87 because I was preparing the vagrant boxes for the upcoming icinga camps. Mainly incorporating the change of moving the iframe module into the main framework.