Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10871] Get rid of padding in controls #2207

Closed
icinga-migration opened this issue Dec 16, 2015 · 7 comments
Closed

[dev.icinga.com #10871] Get rid of padding in controls #2207

icinga-migration opened this issue Dec 16, 2015 · 7 comments
Labels
area/framework Affects third party integration/development bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10871

Created by tgelf on 2015-12-16 19:15:10 +00:00

Assignee: elippmann
Status: Resolved (closed on 2016-01-12 08:00:11 +00:00)
Target Version: 2.2.0
Last Update: 2016-01-12 08:00:11 +00:00 (in Redmine)


We used to have margins for objects sitting in the controls-div. Right now empty controls are higher than the header and steal space from content. This makes it impossible to create a non-usual content using all the space like a fullsize iframe.

Changesets

2016-01-12 07:52:30 +00:00 by elippmann b1049f2

Prepare .controls for removing padding

refs #10871

2016-01-12 07:52:30 +00:00 by elippmann cbfaee8

CSS: Optimize dashboard, column and controls styles

fixes #7350
fixes #10289
fixes #10871

Relations:

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-12-16 19:15:23 +00:00

  • Blocks set to 9894

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-12-17 09:08:15 +00:00

  • Subject changed from Please try to get rid of padding in controls to Get rid of padding in controls
  • Category set to Framework
  • Parent Id set to 5543

Hi Tom,

Just for the records, this was always broken.

Cheers,
Eric

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-12-17 09:19:58 +00:00

lippser wrote:

Just for the records, this was always broken.

Then it always was a bug. However, I wouldn't be that sure, can't you remember that we had margins for .controls > * or similar just to avoid padding exactly there? Doesn't really matter - should be fixed anyways :p

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-12-17 09:21:10 +00:00

I tested your beloved rc1 :)

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-12-17 09:23:14 +00:00

lippser wrote:

I tested your beloved rc1 :)

You would have to travel back in time much more I guess - you remember that beautifuy gray-ish layout by the end of 2014?

@icinga-migration
Copy link
Author

Updated by elippmann on 2016-01-05 14:17:42 +00:00

  • Status changed from New to Assigned
  • Assigned to set to elippmann
  • Target Version set to 2.2.0
  • Parent Id deleted 5543

@icinga-migration
Copy link
Author

Updated by elippmann on 2016-01-12 08:00:11 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset cbfaee8.

@icinga-migration icinga-migration added bug Something isn't working area/framework Affects third party integration/development labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.2.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Affects third party integration/development bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant