New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #10795] http check's URI is really just Path #3755
Comments
Updated by mfriedrich on 2015-12-08 12:54:37 +00:00 That's pretty much the parameter is called in the check_http documentation: https://www.monitoring-plugins.org/doc/man/check\_http.html |
Updated by pas on 2015-12-08 13:35:36 +00:00 Yes, which is misleading too :), and anyone using just check_http will at least find the `--url=PATH default: / ` part of their documentation, which is much more helpful, than the "the request URI" explanation from the icinga docs. |
Updated by mfriedrich on 2015-12-08 13:40:11 +00:00
Send a patch please :) |
Updated by gbeutner on 2015-12-10 08:43:51 +00:00 We should probably update the documentation to explain how this parameter works, e.g. by adding an example. pas: Can you provide a patch for this please? |
Updated by mfriedrich on 2016-02-24 21:12:52 +00:00
I guess that was a "no". I've pushed a simple fix to git master. |
Updated by mfriedrich on 2016-02-24 21:15:03 +00:00
Applied in changeset dcc9772. |
Updated by pas on 2016-03-04 13:22:20 +00:00 Sorry, I did not meant to be rude, however, I had no idea how to clone-fork-edit-commit-attackpull your sources and I thought even just making a simple .patch file and submitting it, and you reviewing it and so on, would take more time. (And then I forgot even to reply, oops.) |
Updated by mfriedrich on 2016-03-04 13:26:52 +00:00 We should probably make this more clear, and add it directly to the website. Meanwhile you can check out https://wiki.icinga.org/display/community/Update+the+Icinga+2+documentation Kind regards, |
Updated by mfriedrich on 2016-03-11 14:50:37 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/10795
Created by pas on 2015-12-08 12:48:03 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2016-02-24 21:15:03 +00:00)
Target Version: 2.4.4
Last Update: 2016-03-11 14:50:37 +00:00 (in Redmine)
Hello!
This is a really annoying bug report about semantics, sorry for that; it took a couple minutes of strace and almost some tcpdump to figure out that check_http's -u wants the path of the resource, not the URI. But the docs are not much help there.
https://github.com/Icinga/icinga2/blob/master/itl/command-plugins.conf#L329
http://docs.icinga.org/icinga2/latest/search?q=http\_uri\#!/icinga2/latest/doc/module/icinga2/chapter/plugin-check-commands?highlight-search=http#plugin-check-command-http
Maybe sometime in the future with a spring cleaning this variable could be renamed.
Thanks.
Changesets
2016-02-24 21:13:03 +00:00 by mfriedrich dcc9772
2016-03-11 14:50:29 +00:00 by mfriedrich aadbe98
The text was updated successfully, but these errors were encountered: