Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10670] State not highlighted in plugin output #2149

Closed
icinga-migration opened this issue Nov 19, 2015 · 4 comments
Closed
Labels
area/monitoring Affects the monitoring module bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10670

Created by Zl0 on 2015-11-19 09:26:24 +00:00

Assignee: elippmann
Status: Resolved (closed on 2015-12-21 12:10:08 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-21 12:10:08 +00:00 (in Redmine)


PluginOutput have spacial function to override states Critical|OK|Warning|Unknown by special css style

/modules/monitoring/application/views/helpers/PluginOutput.php

 '$1OK$2',
        '$1WARNING$2',
        '$1CRITICAL$2',
        '$1UNKNOWN$2',

And it's works, in the source code of html page the spans have current classes, but CSS don't highlighted this events.
And I think UNKNOWN should have "state unknown" but no "error", because CSS have not .bg-color-error(); but have
.bg-color-unknown();

Changesets

2015-12-21 11:25:24 +00:00 by elippmann b49cefa

monitoring: Highlight state in plugin output in the detail area

refs #10670

2015-12-21 12:06:43 +00:00 by elippmann 9f8ee4f

Merge branch 'bugfix/state-colors-in-plugin-output-10670'

fixes #10670
@icinga-migration
Copy link
Author

Updated by elippmann on 2015-11-26 11:42:23 +00:00

  • Subject changed from Highlighting the state in output plugin to State not highlighted in plugin output
  • Category changed from Framework to Monitoring
  • Status changed from New to Assigned
  • Assigned to set to elippmann
  • Target Version set to 2.1.1

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-11-26 11:42:42 +00:00

Hi,

Thanks for the report. We'll fix that issue w/ our next minor release.

Best,
Eric

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-12-21 12:09:52 +00:00

Build !#1195 triggered by the commits 7bafab2, 9f8ee4f, 772ea10, f843ef2, 1b196e6, ca1f412, 6e9b9cb, 627680d, b49cefa failed.

Branch: origin/master
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-12-21 12:10:08 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 9f8ee4f.

@icinga-migration icinga-migration added bug Something isn't working area/monitoring Affects the monitoring module labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.1.1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant