[dev.icinga.com #10654] Render links in acknowledgements, comments and downtimes

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10654

Created by PowellEB on 2015-11-17 00:36:10 +00:00

Assignee: elippmann
Status: Resolved (closed on 2016-02-25 10:40:05 +00:00)
Target Version: 2.2.0
Last Update: 2016-02-25 10:40:05 +00:00 (in Redmine)

---

in icingaweb2 2.0 html links could be rendered in ACKS and comments. This has been used for integrate our
ticketing system to create clickable links in acks and comments.

See attachment-01.

now in icinga2 2.1, the rendering of the html links is gone, and the information is no longer clickable.

see attachment-02.

Can this be changed back or fixed. This totally breaks the integration with our ticketing system.

best regards,
Eric

Attachments

• attachment-01.working_html.png PowellEB - 2015-11-17 00:32:17 +00:00
• attachment-02.broken_html.png PowellEB - 2015-11-17 00:32:54 +00:00
• AddServiceComment.png PowellEB - 2015-11-18 20:38:09 +00:00
• icingaweb2_10654.png ClemensBW - 2015-12-17 18:23:06 +00:00
• icingaweb2_notification_history_html.png mfriedrich - 2016-02-04 14:46:30 +00:00

Changesets

2016-02-15 15:26:52 +00:00 by aklimov b0932d2

Implement escapeComment helper

refs #10654

2016-02-16 13:55:27 +00:00 by aklimov af3abb7

Render simple HTML links (a[href]) in acknowledgements, comments and downtimes

refs #10654

2016-02-25 10:31:13 +00:00 by elippmann f032a67

Merge branch 'feature/render-links-in-acknowledgements-comments-and-downtimes-10654'

resolves #10654

---

Relations:

• duplicates #10654
• duplicates #10654

[icinga-migration]

Updated by PowellEB on 2015-11-18 20:38:50 +00:00

• File added AddServiceComment.png

to reproduce, just use "Add comment" dialog like below

[icinga-migration]

Updated by elippmann on 2015-11-20 13:11:28 +00:00

• Tracker changed from Bug to Feature
• Subject changed from html rendering in Comments/ACKS removed in 2.1 to Render links in acknowledgements, comments and downtimes
• Category changed from UI to Monitoring
• Target Version set to 273

Hi,

I intentionally removed this because it was possible to inject all kinds of HTML. However, we'll support a.

Best,
Eric

[icinga-migration]

Updated by PowellEB on 2015-11-22 00:43:00 +00:00

Eric,
" However, we'll support a."?

What are my options to integrate links again to our ticketing system?

best regards,
Eric

[icinga-migration]

Updated by elippmann on 2015-11-23 09:29:57 +00:00

Hi Eric,

I meant that we'll support the a tag. So your integration should be fine again once implemented. You may want to have a look at the generictts module though. The module allows you to replace text w/ links using a regular expression.

Best,
Eric

PowellEB wrote:

Eric,
" However, we'll support a."?

What are my options to integrate links again to our ticketing system?

best regards,
Eric

[icinga-migration]

Updated by PowellEB on 2015-11-24 07:06:50 +00:00

Thanks Eric. I checked out generictts, and that works fine after a little tweaking.

Thanks again,
Eric P.

[icinga-migration]

Updated by ClemensBW on 2015-12-17 18:23:12 +00:00

• File added icingaweb2_10654.png

dito with notification history @hosts

[icinga-migration]

Updated by mfriedrich on 2016-02-04 14:46:38 +00:00

• File added icingaweb2_notification_history_html.png

I'm seeing this as well, it partially happens for sent notifications.

[icinga-migration]

Updated by aklimov on 2016-02-16 13:56:46 +00:00

• Status changed from New to Feedback
• Assigned to set to elippmann

[icinga-migration]

Updated by elippmann on 2016-02-17 16:56:34 +00:00

• Duplicated set to 10788

[icinga-migration]

Updated by elippmann on 2016-02-24 10:55:11 +00:00

• Status changed from Feedback to Assigned
• Target Version changed from 273 to 2.2.0

[icinga-migration]

Updated by icinga-kanban on 2016-02-25 10:38:44 +00:00

Build !#1279 triggered by the commits 43a7ed3, a34f48c, f032a67, af3abb7, b0932d2 passed successfully.

Branch: origin/master
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2016-02-25 10:40:05 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset f032a67.

[icinga-migration]

Updated by elippmann on 2016-03-07 14:16:32 +00:00

• Duplicated set to 11250