[dev.icinga.com #10603] Line breaks are not respected in acknowledgements, comments and downtimes

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10603

Created by ClemensBW on 2015-11-11 08:32:44 +00:00

Assignee: elippmann
Status: Resolved (closed on 2015-12-21 08:45:03 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-21 08:45:03 +00:00 (in Redmine)

---

Hello,

interesting bug, if i create a comment for a host, the linke break works fine.
If i create a note for a acknowledgment the "\r\n" line break will wrong escaped.

Please see screenshots

Version: 2.0.0
Git commit: ee1ee5a
Git commit date: 2015-10-02

Attachments

• icingaweb2_zeilenumbruch_1.png ClemensBW - 2015-11-11 08:28:58 +00:00 - dont work with ack.
• icingaweb2_zeilenumbruch_works_with_comment.png ClemensBW - 2015-11-11 08:30:42 +00:00 - works with comment
• icingaweb2_zeilenumbruch_dont_work_with_ack.png ClemensBW - 2015-11-11 08:32:30 +00:00 - dont work with ack.

Changesets

2015-11-20 14:17:38 +00:00 by elippmann 91e576d

lib: Add nl2br view helper

refs #10603

2015-11-20 14:18:29 +00:00 by elippmann 24d4389

monitoring: Use View::nl2br() and new comment-list style in the comment overview

refs #10603

2015-11-20 14:34:48 +00:00 by elippmann ea03f40

monitoring: Use View::nl2br() in the downtime overview

refs #10603

2015-11-20 14:44:33 +00:00 by elippmann a874a2c

monitoring: Use View::nl2br() for acknowledgements in the detail area

refs #10603

2015-11-20 14:46:34 +00:00 by elippmann 74b715e

monitoring: Use View::nl2br() for comments in the detail view

refs #10603

2015-11-20 14:48:23 +00:00 by elippmann 9c467eb

monitoring: Use View::nl2br() for downtimes in the detail area

refs #10603

2015-12-16 12:05:32 +00:00 by elippmann d643111

monitoring: Use View::nl2br() for the downtime detail view

refs #10603

2015-12-21 08:39:12 +00:00 by elippmann 11e7d10

Merge branch 'bugfix/line-breaks-in-comments-10603'

fixes #10603

[icinga-migration]

Updated by elippmann on 2015-11-20 13:16:31 +00:00

• Subject changed from String escape in acknowledgment dont work with line break to Line breaks are not respected in acknowledgements, comments and downtimes
• Category changed from Framework to Monitoring
• Target Version set to 273

Hi,

Thanks for the report. Will be fixed soon.

Cheers,
Eric

[icinga-migration]

Updated by elippmann on 2015-11-26 11:36:04 +00:00

• Target Version changed from 273 to 2.1.1

[icinga-migration]

Updated by elippmann on 2015-11-26 11:36:12 +00:00

• Status changed from New to Assigned
• Assigned to set to elippmann

[icinga-migration]

Updated by icinga-kanban on 2015-12-16 12:10:41 +00:00

Build !#1325 triggered by commit d643111 passed successfully.

Branch: origin/bugfix/line-breaks-in-comments-10603
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2015-12-21 08:36:42 +00:00

Build !#1330 triggered by commit 2766b1b passed successfully.

Branch: origin/bugfix/line-breaks-in-comments-10603
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2015-12-21 08:45:03 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 11e7d10.