[dev.icinga.com #10489] Windows Agent: performance data of check_perfmon

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10489

Created by DreiIT on 2015-10-29 13:20:55 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-09-08 14:59:02 +00:00)
Target Version: 2.6.0
Last Update: 2016-12-28 07:19:21 +00:00 (in Redmine)

Icinga Version: v2.3.10
Backport?: Not yet backported
Include in Changelog: 1

---

When check_perfmon outputs it's performance data, 2 different results/performance values are shown:

C:\Program Files (x86)\ICINGA2\sbin>check_perfmon.exe -w 70 -c 90 -P "\Processor(_Total)\% Processor Time"
PERFMON OK "\Processor(_Total)\% Processor Time" = 0.00192303 | perfmon=0.00192303;70;90;; "\Processor(_Total)\% ProcessorTime"=0.00192303

I think it would be sufficient to just display one line but skipping the string "perfmon", e.g.:
PERFMON OK "\Processor(_Total)\% Processor Time" = 0.00192303 | "\Processor(_Total)\% ProcessorTime"=0.00192303;70;90;;

In this way the value would also be distinguishable when used in graphite.

Attachments

• 2016-12-27 11_52_11-Icinga Web.png mwe - 2016-12-27 10:53:48 +00:00 - example of former perfdata-output check_perfmon.exe (prior 2.6.0)

Changesets

2016-09-08 14:57:59 +00:00 by jflach adad718

Fix performance output of check_perfmon

fixes #10489
refs #12679

---

Relations:

• relates #10489

[icinga-migration]

Updated by mfriedrich on 2016-02-24 22:13:48 +00:00

• Status changed from New to Assigned
• Assigned to set to jflach

[icinga-migration]

Updated by jflach on 2016-09-08 14:55:49 +00:00

• Relates set to 12679

[icinga-migration]

Updated by jflach on 2016-09-08 14:59:02 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset adad718.

[icinga-migration]

Updated by jflach on 2016-09-08 14:59:18 +00:00

• Target Version set to 2.6.0

[icinga-migration]

Updated by mwe on 2016-12-27 10:55:02 +00:00

• File added 2016-12-27 11_52_11-Icinga Web.png

The change breaks performance data when using graphite. Current graphite release 0.9.15 cannot deal with special characters like quotes or brackets. Skipping "perfmon" string leads to missing graphite graphs in Icingaweb2 (as you can see in attached image). Also via graphite gui its not possible to add metrics with special graphs.
Solution might be possible in two different approches:

• change every plugin to deliver valid performance data labels
• extend graphitewriter.cpp to escape all special chars except allowed chars
  Second approach might be easier to use, since you solve to problem for all plugins with one change.

[icinga-migration]

Updated by jflach on 2016-12-27 11:40:05 +00:00

Please create a new ticket for this issue.

[icinga-migration]

Updated by mwe on 2016-12-28 07:19:21 +00:00

Opened new issue #13805